Adding TabSyn examples and ensemble attack code#143
Conversation
Upgrading the libraries to address vulnerabilities. This required some code changes with the new libraries functionality and new APIs. None of the fixes were major, but did require some digging and test fixes.
emersodb
left a comment
emersodb
left a comment
There was a problem hiding this comment.
Your changes in response to my comments and those of CodeRabbit look good to me.
For the integration tests, I'm going to have to trust that you've ensured that no changes of significance have happened here.
| [ | ||
| cfg.ks_tv.run, | ||
| cfg.ci_overlap.run, | ||
| cfg.ks_tv.run, |
There was a problem hiding this comment.
It is repeated a couple of lines above this one, so it's an useless line.
| train_data = TabularDataset(numerical_features_train.float(), categorical_features_train) | ||
|
|
||
| # move test data to gpu if available | ||
| numerical_features_test = numerical_features_test.float().to(DEVICE) |
There was a problem hiding this comment.
Maybe we just do both for consistency? The move is idempotent. So if it's already on the device it will no-op anyway.
There was a problem hiding this comment.
I thought the single table integration tests were passing?
There was a problem hiding this comment.
After the upgrades, the values still match on local but not on github anymore, so I have to make new expected values for github actions :/
This reverts commit 1bbc1b4.
…ditional test change" This reverts commit 16127cf.
This reverts commit 03ea35f.
This reverts commit 3f29f62.
This reverts commit 2e4de7c.
This reverts commit 3cca1ec.
This reverts commit c5a44c0.
This reverts commit 2d1bf75.
This reverts commit 052d443.
This reverts commit 7a95b84.
This reverts commit c874920.
This reverts commit b841fda.
This reverts commit 1bece17.
…dditional test change" This reverts commit e57c324.
This reverts commit cab3529.
2 participants
PR Type
Feature
Short Description
Clickup Ticket(s): https://app.clickup.com/t/10524786/868jvwvax
A few things in this PR:
EnsembleAttackTabSynModelRunnertosrc/midst_toolkit/attacks/ensemble/models.pyso the attack knows how to run the modeltest_attack_model.pyfiles to stop pytest thinking they are test filesFYI a lot of the code in the examples was copied from the CTGAN example, and the
EnsembleAttackTabSynModelRunnerwas adapted from the existing TabSyn automated test.Tests Added
No tests added.