[LEGIT] Fix - js/clear-text-cookie#100
Open
idan-local-integration[bot] wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



🔍 The problem
Clear text transmission of sensitive cookie
See issue in Legit
🔒 Fix Details
Fixed cleartext transmission of session cookie
The session cookie was configured without the
secureflag, allowing it to be transmitted over unencrypted HTTP connections. An attacker performing a man-in-the-middle attack could intercept the session cookie in cleartext and hijack the user's session.The fix uncomments the
cookieconfiguration block in the session middleware and enables bothhttpOnly: true(to prevent XSS attacks from accessing the cookie) andsecure: true(to ensure the cookie is only transmitted over HTTPS). This prevents the session cookie from being sent over insecure HTTP connections, protecting it from interception.