[TF2] Fix medigun beam particles not appearing in first-person spectator view - #2000
Open
DeliciousSalad wants to merge 2 commits into
Open
[TF2] Fix medigun beam particles not appearing in first-person spectator view#2000DeliciousSalad wants to merge 2 commits into
DeliciousSalad wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue from: mastercomfig/tf2-patches-old#661
The medigun code assumed only the local player can use a viewmodel, so the beam for remote players in first-person was not attaching to the correct spot, and would also end very quickly after it got triggered.
The code now uses GetAppropriateWorldOrViewModel() instead of pLocalPlayer->GetRenderedWeaponModel(), which more reliably attaches to the correct model/spot based on context.
Here's how it looks in base TF2 at the time of this post:
medigun-before.mp4
And here's how it looks after the fix:
medigun-after.mp4