[TF2] Fix rocket trails being duplicated by reflects - #1999
Open
Tkain wants to merge 1 commit into
Open
Conversation
Tkain
changed the title
|
Optimisation ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Team Fortress 2, whenever a rocket is created or reflected, clients call
C_TFProjectile_Rocket::CreateTrails, which removes any team-specific trails from a rocket and attaches a new set of trails to the rocket.CreateTrailsdoes not check for or remove any non-team-specific rocket trails before creating new trails, however; because of this, each time a rocket is reflected, it receives a duplicated set of non-team-specific rocket trails.This PR fixes this issue by having
C_TFProjectile_Rocket::CreateTrailsonly create a new set of non-team-specific trails the first time it is run for any given rocket, preventing these duplicate trails from being created.See the following videos below for how this issue and this PR's fix appear in gameplay. The difference is more visible closer to the rocket itself.
Before this PR (/w duplicated trails)
before.mp4
With this PR (w/o duplicated trails)
after.mp4
This PR resolves ValveSoftware/Source-1-Games#4171 and ValveSoftware/Source-1-Games#7668.