Fix client crash by skipping bad overlays when compiling the bsp - #1964
Open
bottiger1 wants to merge 1 commit into
Open
Fix client crash by skipping bad overlays when compiling the bsp#1964bottiger1 wants to merge 1 commit into
bottiger1 wants to merge 1 commit into
Conversation
info_overlay faces on a brush entity (func_*) bake an overlay lump the engine resolves against the world brush, crashing clients on map load. Only emit overlay->face bindings for world geometry (entity_num 0).
|
Does the check properly occur after func_detail, func_ladder, etc. are collapsed to the world? I tried to check the code myself, but overlay creation (in EmitFace() in writebsp.cpp) and entity handling (in CMapFile::LoadEntityCallback() in map.cpp) happen so far apart from each other that I was having difficulty telling which happens first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In VBSP, skip overlays that bind to an entity, they crash the client.
Client side code to ignore overlays requires access to engine code.
Description