-
Notifications
You must be signed in to change notification settings - Fork 16
Release: 2.27.3 #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 2.27.3 #222
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| val usercentricsVersion = "2.27.1" | ||
| val usercentricsVersion = "2.27.3" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1. Legacy gradle version mismatch The PR bumps android/build.gradle.kts to use Usercentrics SDK 2.27.3, but android/build-legacy.gradle (shipped as part of the npm package via the android/ folder) still pins usercentrics-ui to 2.27.1, so any consumer using the legacy Gradle script will silently stay on the old native SDK version. Agent Prompt
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [REFACTORING] You hard-bumped val usercentricsVersion = "2.27.3". To avoid manual drift between package.json, podspec and Gradle, consider centralizing version management (e.g. read version from root package.json or a single gradle.properties entry or project property). This reduces the chance of out-of-sync releases and missed version updates across platforms. // android/build.gradle.kts
// TODO: Consider centralizing the SDK version to avoid drift with package.json and podspec.
// For example, you could expose it via gradle.properties or a shared version catalog.
val usercentricsVersion = project.findProperty("usercentricsVersion") as String? ?: "2.27.3"
val reactNativeVersion = "+" |
||
| val reactNativeVersion = "+" | ||
|
|
||
| fun BooleanProperty(name: String): Boolean { | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| { | ||
| "name": "@usercentrics/react-native-sdk", | ||
| "version": "2.27.1", | ||
| "version": "2.27.3", | ||
| "description": "Usercentrics SDK", | ||
| "homepage": "https://usercentrics.com", | ||
| "main": "lib/index.js", | ||
| "types": "lib/index.d.ts", | ||
| "author": "Usercentrics <developer@usercentrics.com>", | ||
| "iosPackageName": "react-native-usercentrics", | ||
| "iosPackageVersion": "2.27.1", | ||
| "iosPackageVersion": "2.27.3", | ||
|
Comment on lines
+3
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [VALIDATION] You updated package version and iosPackageVersion to 2.27.3. Before publishing, verify that the corresponding native artifacts are published and available: the Android/Maven artifact (com.usercentrics.sdk:usercentrics-ui:2.27.3) and the CocoaPods artifact referenced by UsercentricsUI '2.27.3'. If those native packages are not yet published, consumers installing this JS package will fail during pod install / Gradle resolution. Also ensure release tags and CI pipeline (artifact publishing) are executed in the correct order so that native artifacts exist prior to npm publish. |
||
| "license": "SEE LICENSE IN LICENSE", | ||
| "files": [ | ||
| "android", | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[VALIDATION] The changelog entry states a reduction of the public API surface (making types internal/annotated @InternalUsercentricsApi). This can be a breaking change for some consumers. Please confirm and explicitly document compatibility impact and migration guidance: whether this is a breaking change (semver implications), which classes/members are removed or no longer accessible, suggested alternatives, and whether a major/minor version bump is required in downstream SDKs. Add an explicit 'Breaking changes' note if applicable.