Sets prettier + vscode config for consistent on-save formatting#54
Open
LlGC-jop wants to merge 1 commit into
Open
Sets prettier + vscode config for consistent on-save formatting#54LlGC-jop wants to merge 1 commit into
LlGC-jop wants to merge 1 commit into
Conversation
|
@LlGC-jop is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
I had the same issue; this looks much better to me |
Saira-A
approved these changes
Jul 3, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
demiankatz
approved these changes
Jul 4, 2026
demiankatz
left a comment
demiankatz
left a comment
Contributor
There was a problem hiding this comment.
No objections from my side -- but I'll let @jamesmisson decide whether to merge (since he's the last pending review request).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of my commits have had a bunch of irrelevant changes because prettier wasn't running correctly, and questions about consistency have been raised in #39
This updates prettier and vscode settings to use it as the default formatter for astro files.
I've tested this against existing pages that others have worked on recently, and prettier seemed to make the fewest (and least extreme) changes compared to the astro default formatter which mine was falling back on.
I'm not sure which editor everyone else is using however, so if everyone could check out this PR or switch your local config to see if/how it changes things then we can discuss whether to merge or use other settings. Thanks