fix(nodejs): derive discovery endpoint from request origin - #150
Merged
damaz91 merged 3 commits intoJul 29, 2026
Merged
Conversation
ShuoRen-TT
marked this pull request as ready for review
July 29, 2026 12:30
damaz91
approved these changes
Jul 29, 2026
carolinerg1
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Node.js sample currently advertises a hard-coded
http://localhost:3000shopping endpoint in its discovery profile. Requestsserved through a different hostname, HTTPS scheme, or port therefore receive an
endpoint that does not identify the server they contacted.
This change derives the REST endpoint from the request URL origin and adds a
regression test covering HTTPS, a custom hostname, and a non-default port. It
does not add trust for forwarded headers or change any other discovery profile
fields.
Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
No related issue.
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
Validated with Node.js
v20.20.2, matching the repository CI runtime: