fix: preserve fragments when rewriting variant refs - #64
Open
horaceewang-TT wants to merge 2 commits into
Open
Conversation
carolinerg1
requested review from
carolinerg1 and
damaz91
and removed request for
maximenajim and
pjordan
August 5, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes request variant reference rewriting for external JSON Schema $ref values that contain fragments.
Previously, references such as nested/child.json#/$defs/item were skipped because the preprocessing logic treated every reference containing # as a local reference.
The updated implementation separates the external file path from the fragment, rewrites the file path to its request variant, and appends the original fragment unchanged:
nested/child_create_request.json#/$defs/item
Purely local references such as #/$defs/local remain unchanged.
A regression test has been added to verify both external fragment rewriting and local reference handling.
Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
#63
Checklist
!for breaking changes).Screenshots / Logs (if applicable)