feat: Disable PMTUD if using DA - #4126
Open
simon-lemay-unity wants to merge 3 commits into
Open
Conversation
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-2.0.0 #4126 +/- ##
=================================================
+ Coverage 73.86% 73.95% +0.08%
=================================================
Files 172 172
Lines 28099 28105 +6
=================================================
+ Hits 20756 20785 +29
+ Misses 7343 7320 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
|
EmandM
reviewed
Aug 19, 2026
EmandM
left a comment
EmandM
left a comment
Member
There was a problem hiding this comment.
Not sure if this requires a CHANGELOG entry?
Contributor
Author
I went back and forth on this and opted not to include one since there's no change in behavior until the defaults in UTP change, which they won't until Unity 7. If you think we'd better have an entry I'm happy to add one though. |
Contributor
Author
|
@EmandM The only CI failure on the PR is a job that also fails on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
At some point UTP will start enabling path MTU discovery (PMTUD) by default. When that happens, we don't want it enabled in NGO if using distributed authority since the CMB server doesn't support that part of the UTP protocol.
Jira ticket
N/A
Changelog
None
Documentation
No documentation changes or additions were necessary.
Testing & QA
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?Up-port
3.X: PR #4127
Backports
N/A