Use UnityAPI on iOS when using Swift trampoline - #459
Open
aurimasc wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Harness Review
The Swift-project notification observer integration now uses Unity’s public Swift API directly, and I examined the affected lifecycle path, package metadata, and the version-specific Xcode post-processing logic. The stated Unity 6.6 boundary is consistent with the direct header dependency; no actionable defects were substantiated.
Reviewed commit 8aa6e61
🤖 Helpful? 👍/👎
xTheEc0
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.unity3d.com/browse/PLAT-21965
Change integration with the Swift trampoline to use Unity public API directly from Objective-C++ code without swift bridge.
The new implementation is much cleaner and safer, with a price that we lose compatibility with Unity 6.5, but that was accepted.
Tested on simulator using 6.6 and trunk that remote notifications have been correctly subscribed to and device token has been received.