fix: remove run-as-me=true propagation override#1010
Open
maxduu wants to merge 1 commit into
Open
Conversation
maxduu
changed the title
There was a problem hiding this comment.
Pull request overview
Removes the previous “RunAsMe=true propagation override” path for agent process tools, aligning behavior with the intended deployment-time configuration (Orchestrator package requirements) and updating tests/versioning accordingly.
Changes:
- Removed user-token-based RunAsMe decision logic from the tool factory and stopped passing
run_as_meinto process tool creation. - Updated
create_process_toolinvocation behavior soprocesses.invoke_asyncis no longer called with arun_as_mekwarg. - Updated unit tests and bumped project/lockfile version to
0.14.17.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Bumps locked package version to 0.14.17. |
| pyproject.toml | Bumps project version to 0.14.17. |
| src/uipath_langchain/agent/tools/tool_factory.py | Removes RunAsMe propagation logic and simplifies process tool creation call site. |
| src/uipath_langchain/agent/tools/process_tool.py | Removes RunAsMe forwarding to invoke_async and updates process tool factory signature. |
| tests/agent/tools/test_tool_factory.py | Adjusts assertions to match the new create_process_tool call signature. |
| tests/agent/tools/test_process_tool.py | Removes RunAsMe-related expectations/tests to match the updated invocation behavior. |
Comment on lines
+45
to
46
| def create_process_tool(resource: AgentProcessToolResourceConfig) -> StructuredTool: | ||
| """Uses interrupt() to suspend graph execution until process completes (handled by runtime).""" |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer propagates run-as-me=true for agent's process tools. Note that this logic was not working correctly in the past (should have been checking for
robot.userrather thanusertype token) and we are also not using this method of overriding RunAsMe=true. Instead we're relying on package-requirements of the Agent, set in Orchestrator.