feat(docs): add core input component pages (batch A)#943
Draft
heatherbarranco wants to merge 1 commit into
Draft
feat(docs): add core input component pages (batch A)#943heatherbarranco wants to merge 1 commit into
heatherbarranco wants to merge 1 commit into
Conversation
Ports Button, Checkbox, Combobox, Date picker, Text input, and Toggle switch from the stale content-guidelines-docs branch (UiPath#766) as the first of several small batches, since all six have exact-match component coverage in both Zeroheight and apollo-wind already. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds the first batch of component documentation pages to the apps/apollo-docs Next.js docs app, registering them in the Components sidebar navigation. This helps replace previously stalled Zeroheight-sourced documentation by incrementally porting “exact match” components that already exist in apollo-wind.
Changes:
- Added 6 new component MDX pages: Button, Checkbox, Combobox, Date picker, Text input, Toggle switch
- Registered the new component routes in
apps/apollo-docs/app/components/_meta.tsfor sidebar/nav visibility
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/apollo-docs/app/components/button/page.mdx | New Button documentation page content |
| apps/apollo-docs/app/components/checkbox/page.mdx | New Checkbox documentation page content |
| apps/apollo-docs/app/components/combobox/page.mdx | New Combobox documentation page content |
| apps/apollo-docs/app/components/date-picker/page.mdx | New Date picker documentation page content |
| apps/apollo-docs/app/components/text-input/page.mdx | New Text input documentation page content |
| apps/apollo-docs/app/components/toggle-switch/page.mdx | New Toggle switch documentation page content |
| apps/apollo-docs/app/components/_meta.ts | Adds nav entries for the new component pages |
Comment on lines
+75
to
+76
| - [Icon button](/components/icon-button) | ||
| - [Link](/components/link) |
|
|
||
| ## Related | ||
|
|
||
| - [Radio button](/components/radio-button) |
| - There are only two mutually exclusive options | ||
| - The change should take effect immediately, without a separate submit action | ||
|
|
||
| For a set of mutually exclusive options that require an additional step to apply (e.g., pressing Save), use a [Radio button](/components/radio-button) instead. For multiple selections requiring additional steps, use a [Checkbox](/components/checkbox). |
| ## Related | ||
|
|
||
| - [Checkbox](/components/checkbox) | ||
| - [Radio button](/components/radio-button) |
| ## Accessibility | ||
|
|
||
| - Read-only components remain navigable by keyboard so users can review and copy values; disabled components are not keyboard-accessible | ||
| - Placeholder text must be associated with an `aria-label` for assistive technologies |
Comment on lines
+79
to
+80
| - [Dropdown](/components/dropdown) | ||
| - [Rich-text editor](/components/rich-text-editor) |
Comment on lines
+36
to
+38
| - [Dropdown](/components/dropdown) | ||
| - [List](/components/list) | ||
| - [Menu](/components/menu) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of several small batches replacing the stale #766 (closed, unmerged — auto-closed for staleness, not rejected in review). Adds 6 of the 22 "exact match" components: ones documented in Zeroheight and already built in apollo-wind with matching names, so there's no open naming/scope question blocking them.
Page content is ported as-is from #766's
feat/content-guidelines-docsbranch (originally sourced from Zeroheight) — not rewritten. Registered inapp/components/_meta.tsalongside the existingoverviewpage.Follow-up batches planned:
Test plan
next dev🤖 Generated with Claude Code