Skip to content

fix(apollo-react): add horizontal padding to BaseNode inline edit inputs [MST-12529]#941

Open
kittyyueli wants to merge 1 commit into
mainfrom
claude/friendly-curie-xy4jws
Open

fix(apollo-react): add horizontal padding to BaseNode inline edit inputs [MST-12529]#941
kittyyueli wants to merge 1 commit into
mainfrom
claude/friendly-curie-xy4jws

Conversation

@kittyyueli

Copy link
Copy Markdown
Member

CLAUDE BUG BURN-DOWN

Claude session: https://claude.ai/code/session_01CcawHHGweJQJN34afuLHjM

Summary

  • Double-clicking a BaseNode label/sub-label (e.g. a Case Management trigger name) to edit it renders a dashed-outline textarea with text flush against the edges, because EditableLabel only applied px-1.5/py-0.5 when a labelBackgroundColor was set.
  • labelBackgroundColor is only used by AgentNode/ResourceNode; every other BaseNode consumer (including Case Management triggers) edits with zero horizontal padding.
  • Made the horizontal padding (px-1.5) unconditional in EditableLabel (NodeLabel.tsx), keeping the vertical py-0.5 tied to labelBackgroundColor (matching the Header/SubHeader "chip" styling, which is unaffected by this change).

Root cause

packages/apollo-react/src/canvas/components/BaseNode/NodeLabel.tsx - EditableLabel's className previously gated px-1.5 py-0.5 behind backgroundColor && ..., so inline edit inputs without a background color got no padding despite always rendering a visible outline-dashed box.

Test plan

  • pnpm turbo run lint:fix --filter=@uipath/apollo-react (no diagnostics on changed files)
  • pnpm turbo run build --filter=@uipath/apollo-react (build + type declarations succeed)
  • vitest --run for NodeLabel.test.tsx / BaseNode.test.tsx / BaseNodeContainer.test.tsx (79/79 passing)
  • Added a regression test asserting the edit inputs carry px-1.5 regardless of labelBackgroundColor

Fixes MST-12529.


Generated by Claude Code

…uts [MST-12529]

The label/description textareas rendered when double-clicking a
BaseNode only got px-1.5/py-0.5 when a labelBackgroundColor was set,
so nodes without one (e.g. case triggers) show a dashed outline box
with text flush against its edges while editing.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CcawHHGweJQJN34afuLHjM
Copilot AI review requested due to automatic review settings July 21, 2026 09:19
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Jul 21, 2026, 02:25:22 AM
apollo-docs 🟢 Ready Preview, Logs Jul 21, 2026, 02:25:22 AM
apollo-landing 🟢 Ready Preview, Logs Jul 21, 2026, 02:25:22 AM
apollo-vertex 🟢 Ready Preview, Logs Jul 21, 2026, 02:25:22 AM

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1950 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1720
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the inline-edit UX for BaseNode labels in apollo-react by ensuring the editable textarea inputs always include horizontal padding, even when no labelBackgroundColor is provided (the common case for most BaseNode consumers).

Changes:

  • Made px-1.5 unconditional for EditableLabel textarea styling while keeping py-0.5 conditional on backgroundColor.
  • Added a regression test asserting both label and sub-label edit inputs include px-1.5 regardless of background color.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/apollo-react/src/canvas/components/BaseNode/NodeLabel.tsx Applies unconditional horizontal padding to inline-edit textareas to prevent text from being flush against the dashed outline.
packages/apollo-react/src/canvas/components/BaseNode/NodeLabel.test.tsx Adds a regression test to validate the new padding behavior for both editable inputs.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 9.0% 43.82 MB 57.31 MB ±0
@uipath/apollo-react 37.2% — (2 untracked) 7.38 MB 28.16 MB +9 B
@uipath/apollo-wind 41.0% 397.5 KB 2.58 MB +6 B
@uipath/ap-chat 85.8% 43.43 MB 55.92 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@kittyyueli
kittyyueli marked this pull request as ready for review July 21, 2026 09:26
@kittyyueli kittyyueli self-assigned this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants