submitting_jobs.md - #293
Open
Graviton28 wants to merge 1 commit into
Open
Conversation
Graviton28
marked this pull request as ready for review
August 4, 2026 04:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found a real bug testing this one. the interactive section claims running
bash helloworld_parallel.sbatchunder an 8-task salloc allocation prints "Hello World" 8 times - it doesn't, plain bash only ever runs a script once no matter how many tasks you asked for. confirmed by actually testing it (only got 1 line), then fixed it to usempirun -np 8instead and got the real 8-line output.also fixed the dead link to
pbs_scripts2.md(doesn't exist, never has as far as I can tell) - pointed it atsubmitting_sbatch_jobs.mdinstead which actually covers writing a slurm script. added the actualhelloworld_parallel.sbatchscript content too since the doc referenced it without ever showing it. split the combined command+output code blocks into separate ones to match the rest of the repo's formatting, and used real job IDs/hostnames from testing instead of the placeholder ones.heads up: this file isn't linked from README at all, and its content pretty heavily overlaps with
submitting_sbatch_jobs.md(which already covers hello world + sbatch/salloc more thoroughly). didn't touch that structural question, just fixed what was actually broken in the file as it exists.