fix(publish): create spec dir on first publish into a pristine hub#10
Merged
Conversation
publish.ts assumed spec/ already existed (the hub was bootstrapped with a committed spec). On a first publish into a pristine hub the directory is absent and copyFileSync fails with ENOENT. mkdir -p the spec dir before writing. Validated locally end-to-end: pristine hub -> clean 'Initial published spec.' baseline, files written, commit+push OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The baseline redrive (production pipeline) failed:
ENOENT: copyfile '/tmp/openapi.json' -> 'spec/openapi.json'. The hub reset removed thespec/directory, andpublish.tsassumed it always existed (the hub was originally bootstrapped with a committed spec). The first publish into a pristine hub has nospec/dir.Fix
fs.mkdirSync(path.dirname(SPEC_JSON), { recursive: true })before writing the spec.Validation
Ran the fixed script locally against a pristine clone (origin pointed at a throwaway bare repo, no token): it created
spec/, wroteopenapi.json/openapi.yaml/provenance.json, committed and pushed, and produced a cleanInitial published spec.changelog entry. It stopped only at the release step (no token), which is downstream of this fix.