feat: @y/prosemirror v2 + @y/y v14 integration#2739
Draft
nperez0111 wants to merge 24 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nperez0111
force-pushed
the
y-prosemirror-v14
branch
from
776ca34 to
5fae30a
Compare
nperez0111
force-pushed
the
y-prosemirror-v14
branch
from
5fae30a to
d70df64
Compare
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
force-pushed
the
y-prosemirror-v14
branch
from
00569fc to
38d3e13
Compare
nperez0111
force-pushed
the
y-prosemirror-v14
branch
from
38d3e13 to
a56bb0d
Compare
nperez0111
force-pushed
the
decouple-yjs
branch
3 times, most recently
from
a9f7067 to
2ad90dc
Compare
nperez0111
force-pushed
the
y-prosemirror-v14
branch
from
a56bb0d to
6b9a6f6
Compare
nperez0111
force-pushed
the
decouple-yjs
branch
4 times, most recently
from
e44394d to
17ab49f
Compare
nperez0111
force-pushed
the
y-prosemirror-v14
branch
from
6b9a6f6 to
d13fcac
Compare
|
Make suggestionFixture.sync() async and wait for the ySyncPlugin to flush PM->Y into baseDoc before encoding it into suggestionDoc. The previous synchronous sync() encoded a stale/empty baseDoc, causing racy/cross-contaminated baseDoc snapshots in addRemoveBlocks tests. - await sync() at all single-user fixture call sites - capture baseDocXml before enableSuggestions() so baseDoc snapshots are deterministic and not polluted by attribution marks - update suggestionDoc/editorHtml snapshots for v14 userIds="" attr - re-enable add-heading-to-empty-doc and delete-image-block (now pass)
Wire the 13-versioning-yjs14 example to the YHub versioning adapter and make YHub's /activity timeline the source of truth for versions. - yhub.ts: fix v1/v2 update encoding mismatch (getContent converts v1->v2, create writes v1); list/create/restore now derive version identity from YHub activity timestamps; drop unused metaStore concept and updateSnapshotName - Versioning.ts: make Yjs adapter applyRestore a no-op since YHub /rollback publishes the reverting update over live sync - Snapshot.tsx: render version name as static text when updateSnapshotName is unsupported instead of a read-only input - example: point websocket + versioning at YHub, load versions on mount, remove localStorage/named-filter scaffolding
- remove preloadDemoDocument seeding and its versionData.json/preloadVersions.ts - bump @y/prosemirror to ^2.0.0-4 in generated playground examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the new
@y/prosemirrorv2 and@y/yv14 (Yjs 14) packages alongside the existing Yjs 13 (yjs,y-prosemirror) integration. This includes new collaboration bindings, versioning extensions, forked document support, and suggestion tracking built on the v14 APIs.Rationale
The
@y/yv14 ecosystem introduces significant improvements over Yjs 13, including better TypeScript support, a new protocol layer, and improved ProseMirror bindings. This PR adds first-class support for v14 while keeping full backward compatibility with Yjs 13.Changes
New
@blocknote/core/yentry point@y/prosemirrorv2 with TipTap/BlockNote@y/prosemirrorv2@y/yv14 APIsVersioning system (
@blocknote/coreextensions)yjspackageVersioningSidebar,Snapshot,CurrentSnapshotEditor improvements
y-attributed-deletemark) to avoid corrupting suggestionsgetBlockInfoFromPosnow handles nodes with marks (suggested changes)moveBlocks,replaceBlocks,splitBlock,nestBlock) to handle marked/attributed nodesPatches
@y/prosemirror@2.0.0-2— extensive patch for BlockNote compatibility@y/y@14.0.0-rc.16— minor patchlib0@1.0.0-rc.13— compatibility patchExamples
Tests
Impact
@y/packages are optional peer dependencies@blocknote/core/yexport for v14 users, parallel to existing@blocknote/core/yjsScreenshots/Video
Live examples:
Checklist