fix(node-gha): preserve action release commit parents#157
Merged
Conversation
Coverage Report for CI Build 28399353701Coverage increased (+0.2%) to 64.171%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the node-gha publish flow to avoid losing commit parent information when publishing from shallow Git clones (common in GitHub Actions), ensuring amended release commits keep their original ancestry.
Changes:
- Detect shallow repositories during publish and fetch additional git history before creating/updating release refs.
- Add a regression test that publishes from a
--depth 1clone and verifies parent preservation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/node-gha/src/publish.ts | Detect shallow clones and fetch history/tags before checking out the release commit for publishing. |
| packages/node-gha/src/publish.spec.ts | Add coverage for publishing from a shallow clone and validating commit-parent preservation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| '--is-shallow-repository' | ||
| ) === 'true' | ||
|
|
||
| if (isShallowRepository) { |
Comment on lines
+98
to
+102
| const project = new NodeGhaProject({ | ||
| path: join(clonePath, 'package.json') | ||
| }) | ||
|
|
||
| await project.gitClient.setConfig('user.name', 'Tester Testerson') |
dangreen
force-pushed
the
fix/node-gha-preserve-release-parents
branch
from
d4fc588 to
35d7445
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.