Skip to content

fix(node-gha): stage action files without build commands#153

Merged
dangreen merged 2 commits into
mainfrom
fix/node-gha-stage-files-without-build
Jun 29, 2026
Merged

fix(node-gha): stage action files without build commands#153
dangreen merged 2 commits into
mainfrom
fix/node-gha-stage-files-without-build

Conversation

@dangreen

Copy link
Copy Markdown
Member

No description provided.

@coveralls

coveralls commented Jun 29, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28390756608

Coverage increased (+0.05%) to 63.052%

Details

  • Coverage increased (+0.05%) from the base build.
  • Patch coverage: 2 of 2 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 832
Covered Lines: 584
Line Coverage: 70.19%
Relevant Branches: 459
Covered Branches: 230
Branch Coverage: 50.11%
Branches in Coverage %: Yes
Coverage Strength: 9.93 hits per line

💛 - Coveralls

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts node-gha publishing so GitHub Action files listed in files are staged even when no build commands are configured, enabling “prebuilt/checked-in” action artifacts to be published correctly.

Changes:

  • Stage configured files during publish regardless of whether build commands are present.
  • Add a unit test ensuring existing action files are included in the published tag without running build steps.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/node-gha/src/publish.ts Stage action files whenever files.length is non-zero (not gated by build commands).
packages/node-gha/src/publish.spec.ts Adds coverage for publishing when files already exist and no build command is provided.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/node-gha/src/publish.ts Outdated
Comment thread packages/node-gha/src/publish.spec.ts
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@dangreen dangreen merged commit 44125c7 into main Jun 29, 2026
6 checks passed
@dangreen dangreen deleted the fix/node-gha-stage-files-without-build branch June 29, 2026 17:31
@github-actions github-actions Bot mentioned this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants