[codex] PR_26171_031 idea board inline tree grid actions#6
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f79af9b19d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| state.selectedIdeaId = id; | ||
| state.addingIdea = false; |
There was a problem hiding this comment.
If a creator clicks Add Note and then Add Idea before saving or canceling the note, state.addingNote is still true when the new idea is saved. This assignment switches the selected idea to the new row, so the pending note input is re-rendered under the new idea and saving it stores the note on the wrong idea; clear the note add/edit state before selecting the new idea.
Useful? React with 👍 / 👎.
| if (action === "add") { | ||
| state.addingNote = true; | ||
| state.editingNoteId = null; | ||
| updateStatus(root, `Adding a note for ${selectedIdea().title}.`); | ||
| render(root); |
There was a problem hiding this comment.
When an Add/Edit Idea row has unsaved text and the creator clicks Add Note in the expanded notes area, this branch sets the note state and immediately re-renders while leaving state.addingIdea/state.editingIdeaId active. Because idea input values are not stored in state, the idea row is rebuilt from blank/original values and the creator's draft title, pitch, or status changes are lost; cancel or preserve the idea draft before rendering the note input.
Useful? React with 👍 / 👎.
2 participants
Summary
Validation
node --check toolbox/idea-board/index.jsnode --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjsnode --check tests/playwright/tools/ToolboxRoutePages.spec.mjsnpx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=linenpx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"npm run test:workspace-v2git diff --cached --checkArtifact
tmp/PR_26171_031-idea-board-inline-tree-grid-actions_delta.zip(76594 bytes)Full samples smoke intentionally not run per request.