Skip to content

PR_26171_GAMMA_024-local-api-sqlite-reference-cleanup#46

Merged
ToolboxAid merged 1 commit into
mainfrom
pr/26171-GAMMA-024-local-api-sqlite-reference-cleanup
Jun 21, 2026
Merged

PR_26171_GAMMA_024-local-api-sqlite-reference-cleanup#46
ToolboxAid merged 1 commit into
mainfrom
pr/26171-GAMMA-024-local-api-sqlite-reference-cleanup

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

TEAM ownership: GAMMA.

Cleans the remaining active Local API SQLite route metadata after the Messages and Game Journey Postgres migrations landed in main. The change removes the remaining literal SQLite labels from src/dev-runtime/server/local-api-router.mjs while preserving existing response keys, Postgres-backed Messages routes, and Postgres-backed Game Journey completion metrics routes.

This branch was created from fresh main and does not pull or depend on open PR #43 / team/GAMMA/admin.

Validation

Passed:

  • git diff --check
  • git diff --cached --check
  • node --check src/dev-runtime/server/local-api-router.mjs
  • node --test --test-name-pattern "Messages Local API" tests/dev-runtime/DbSeedIntegrity.test.mjs
  • npx playwright test tests/playwright/tools/GameJourneyTool.spec.mjs --config=codex_playwright_system_chrome.config.cjs --project=playwright -g "Game Journey Local API persists completion metrics to Postgres"
  • Inline Local API route check for /api/project-workspace/projects, verifying the cleaned Local DB adapter label and no SQLite text in that response.
  • Targeted text check confirmed no sqlite, messages-sqlite, createMessagesSqliteService, DatabaseSync, node:sqlite, messages.sqlite, or GAMEFOUNDRY_MESSAGES_SQLITE_PATH match remains in src/dev-runtime/server/local-api-router.mjs.

Observed outside scoped lane:

  • A broad node --test tests/dev-runtime/DbSeedIntegrity.test.mjs run passed the Messages Local API case but failed two unrelated /api/local-db/snapshot seed/reseed cases. Those local-db snapshot cases are outside this cleanup scope and were not used as completion evidence.

Skipped:

  • Full samples smoke: out of scope.
  • Full Playwright suite: the change is limited to Local API route metadata labels.
  • Archive/history cleanup: explicitly out of scope.

Reports

  • docs_build/dev/reports/codex_review.diff
  • docs_build/dev/reports/codex_changed_files.txt
  • docs_build/dev/reports/PR_26171_GAMMA_024-local-api-sqlite-reference-cleanup.md
  • docs_build/dev/reports/PR_26171_GAMMA_024-local-api-sqlite-reference-cleanup-manual-validation-notes.md
  • docs_build/dev/reports/PR_26171_GAMMA_024-local-api-sqlite-reference-cleanup-instruction-compliance-checklist.md
  • docs_build/dev/reports/playwright_v8_coverage_report.txt
  • docs_build/dev/reports/coverage_changed_js_guardrail.txt

ZIP

tmp/PR_26171_GAMMA_024-local-api-sqlite-reference-cleanup_delta.zip

Do not merge until explicit EOD approval.

@ToolboxAid ToolboxAid marked this pull request as ready for review June 21, 2026 15:51
@ToolboxAid ToolboxAid merged commit 6e03515 into main Jun 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant