[codex] PR_26171_030 idea board workflow fix#4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dd40355c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }); | ||
| page.on("request", (request) => { | ||
| if (request.url().includes("/api/") && request.method() !== "GET") { | ||
| mutatingApiRequests.push(`${request.method()} ${request.url()}`); |
There was a problem hiding this comment.
When this new spec is run by itself in a clean repo-server environment without a configured product DB, the Idea Board page loads tool-display-mode.js, which fetches /api/toolbox/registry/snapshot; because this test only sets the public API URLs and does not configure the fake/local data source before this page.goto, that request returns 500 and is recorded in failedRequests, so the required targeted Playwright validation fails before the notes workflow is exercised. Configure the test server data source/session like the workspace harness does, or avoid treating the registry lookup as an unexpected failure for this wireframe test.
Useful? React with 👍 / 👎.
…/ToolboxAid/HTML-JavaScript-Gaming into codex/fix-idea-board-pr-workflow # Conflicts: # docs_build/dev/reports/codex_changed_files.txt # docs_build/dev/reports/codex_review.diff
…pr-workflow # Conflicts: # docs_build/dev/reports/codex_changed_files.txt # docs_build/dev/reports/codex_review.diff
2 participants
Summary
Validation
node --check toolbox/idea-board/index.jsnode --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjsnode --check tests/playwright/tools/ToolboxRoutePages.spec.mjsnode --check tests/playwright/tools/RootToolsFutureState.spec.mjstoolbox/idea-board/index.htmlnpx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=linenpx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches"npm run test:workspace-v2git diff --cached --checkArtifact
tmp/PR_26171_030-idea-board-workflow-fix_delta.zip(100283 bytes)Full samples smoke intentionally not run per request.