Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# PR_26171_BETA_079 Manual Validation Notes

## Review
- Confirmed the Messages table remains the parent table.
- Confirmed clicking a non-control Message row cell opens the Message Parts child table.
- Confirmed Message Parts expose Text, Emotion, TTS Profile, Status, and Actions columns.
- Confirmed Add Part opens an inline child-table editor with Emotion and TTS Profile selectors.
- Confirmed TTS Studio compatibility validation still passes.

## Manual Browser Coverage
- Covered by targeted Playwright validation for Message Studio load, row expansion, add/edit flows, and Message Part selectors.
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# PR_26171_BETA_079 Validation Report

## Commands
- PASS: node --check toolbox/messages/messages.js
- PASS: npx playwright test tests/playwright/tools/MessagesTool.spec.mjs
- PASS: npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs
- PASS: npm run test:workspace-v2
- PASS: git diff --check

## Targeted Results
- Message Studio Playwright tests: 2 passed.
- Text To Speech compatibility Playwright tests: 3 passed.
- Project Workspace legacy validation: 5 passed.

## Notes
- npm run test:workspace-v2 is a legacy command name; user-facing language remains Project Workspace.
- Standard generated validation-report churn was restored before staging this PR.
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# PR_26171_BETA_079-message-studio-parent-child-table-completion

## Team Ownership
- TEAM: BETA
- Ownership source: docs_build/dev/PROJECT_MULTI_PC.txt
- Scope confirmed: Message Studio, Messages, and TTS selection integration are owned by Team BETA.

## Summary
- Completed Message Studio row-click behavior for the Messages parent table.
- Kept Message Parts as the selected Message child table.
- Kept Message Part controls for Text, Emotion, TTS Profile, Status, and Actions.
- Preserved existing Play Part, Play Message, and Stop controls for the next playback PR.

## Scope Guard
- Theme V2 only.
- External JS only.
- No inline styles, style blocks, inline handlers, page-local CSS, or tool-local CSS.
- No database schema changes.
- No separate Emotion Studio.
- No browser-owned product data source of truth added.
11 changes: 5 additions & 6 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/codex_review.diff
docs_build/dev/reports/PR_26171_BETA_077-tts-profile-parent-child-table-manual-validation-notes.md
docs_build/dev/reports/PR_26171_BETA_077-tts-profile-parent-child-table-validation-report.md
docs_build/dev/reports/PR_26171_BETA_077-tts-profile-parent-child-table.md
tests/playwright/tools/TextToSpeechFunctional.spec.mjs
toolbox/text-to-speech/index.html
toolbox/text-to-speech/text2speech.js
docs_build/dev/reports/PR_26171_BETA_079-message-studio-parent-child-table-completion-manual-validation-notes.md
docs_build/dev/reports/PR_26171_BETA_079-message-studio-parent-child-table-completion-validation-report.md
docs_build/dev/reports/PR_26171_BETA_079-message-studio-parent-child-table-completion.md
tests/playwright/tools/MessagesTool.spec.mjs
toolbox/messages/messages.js
353 changes: 79 additions & 274 deletions docs_build/dev/reports/codex_review.diff

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion tests/playwright/tools/MessagesTool.spec.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ async function addPart(page, values) {
}

async function openMessageParts(page, messageName) {
await page.locator("[data-messages-name-cell]").filter({ hasText: messageName }).click();
await page.locator("[data-messages-row]").filter({ hasText: messageName }).locator("td").nth(1).click();
}

test("Message Studio renders Messages with child Message Parts and plays ordered parts", async ({ page }) => {
Expand Down Expand Up @@ -198,7 +198,11 @@ test("Message Studio renders Messages with child Message Parts and plays ordered
const messageRow = page.locator("[data-messages-row]").filter({ hasText: "Bat Encounter" });
const messageNameCell = page.locator("[data-messages-name-cell]").filter({ hasText: "Bat Encounter" });
await expect(page.locator("[data-messages-segment-host]")).toHaveCount(0);
await expect(messageNameCell).toHaveAttribute("aria-expanded", "false");
await messageRow.locator("td").nth(3).click();
await expect(page.locator("[data-messages-segment-host]")).toBeVisible();
await expect(messageNameCell).toHaveAttribute("aria-expanded", "true");
await messageRow.locator("td").nth(2).click();
await expect(page.locator("[data-messages-segment-host]")).toHaveCount(0);
await messageNameCell.click();
await expect(page.locator("[data-messages-segment-host]")).toBeVisible();
Expand Down
2 changes: 1 addition & 1 deletion toolbox/messages/messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -1188,7 +1188,7 @@ elements.table?.addEventListener("click", async (event) => {
render();
return;
}
if (messageNameCell && row) {
if ((messageNameCell || row) && row) {
state.selectedMessageKey = state.selectedMessageKey === row.dataset.messagesRow ? "" : row.dataset.messagesRow;
state.selectedSegmentKey = "";
state.editingSegmentKey = "";
Expand Down
Loading