Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# PR_26171_BETA_075 Instruction Compliance Checklist

Team: BETA

- PASS: Started from `main`.
- PASS: Pulled latest `origin/main` before branch creation.
- PASS: Repository was clean before creating `pr/26171-BETA-075-tts-message-table-cleanup`.
- PASS: PR name includes required TEAM token `BETA`.
- PASS: `docs_build/dev/PROJECT_MULTI_PC.txt` assigns Messages, Text To Speech, and TTS work to Team BETA.
- PASS: Active implementation paths are `toolbox/text-to-speech/` and `toolbox/messages/`.
- PASS: No `tools/text2speech/` path was created.
- PASS: Theme V2 only; no inline styles, style blocks, inline handlers, page-local CSS, or tool-local CSS were added.
- PASS: Validation scope includes targeted TTS Studio, targeted Message Studio, and legacy `npm run test:workspace-v2`.
- PASS: Required reports and repo ZIP under `tmp/` are required before completion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# PR_26171_BETA_075 Manual Validation Notes

Team: BETA

- Reviewed `toolbox/text-to-speech/index.html` and confirmed no Named Sentence, Queue, or Output Summary surface remains.
- Reviewed `toolbox/text-to-speech/text2speech.js` and confirmed preview playback uses TTS Profile plus Emotion Settings instead of a named-sentence queue.
- Reviewed `toolbox/messages/messages.js` and confirmed Message Parts visible columns are Text, Emotion, TTS Profile, Status, and Actions.
- Confirmed no inline styles, style blocks, inline event handlers, page-local CSS, or tool-local CSS were added.
- Confirmed no `tools/text2speech/` path was created.
- Confirmed required delta ZIP path: `tmp/PR_26171_BETA_075-tts-message-table-cleanup_delta.zip`.
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# PR_26171_BETA_075 Validation Report

Team: BETA

## Commands

- PASS: `node --check toolbox/text-to-speech/text2speech.js`
- PASS: `node --check toolbox/messages/messages.js`
- PASS: `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs`
- Result: 3 passed.
- PASS: `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --trace=off`
- Result: 2 passed after scoping the Message Parts table assertion.
- PASS: `node --test tests/tools/Text2SpeechShell.test.mjs`
- Result: 4 passed.
- PASS: `npm run test:workspace-v2`
- Result: 5 passed.
- Note: Command name is legacy; user-facing language is Project Workspace and Game Hub.
- PASS: `git diff --check`
- Result: no whitespace errors; Git reported line-ending notices only.

## Validation Notes

- Initial `npm run test:workspace-v2` runs exposed stale root toolbox expectations for the current registered toolbox count, duplicate Game Hub entries, and Publish group visibility.
- Those expectations were updated in the targeted workspace test file, then the legacy workspace command passed.
- Node emitted experimental SQLite warnings during validation; no validation failed because of those warnings.
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# PR_26171_BETA_075 TTS Message Table Cleanup

Team: BETA

## Summary

- Removed the duplicate center summary text `TTS Studio` from the Text To Speech summary row.
- Removed the stale Text To Speech left-column Voice Filters, Presets, Delivery, and Named Sentence controls.
- Removed the stale Text To Speech Queue and right-column Output Summary surfaces.
- Kept voice, language, gender, and age editing in the TTS Profile inline table row.
- Kept pitch, rate, volume, and preset editing in the Emotion Settings inline table row.
- Updated Text To Speech preview playback to speak the current text through the selected TTS Profile and selected/neutral Emotion Setting.
- Updated Message Studio Message Parts to show Text, Emotion, TTS Profile, Status, and Actions while preserving internal display order.
- Updated focused Playwright tests and workspace count/group expectations to match the current registered toolbox surface.

## Requirement Checklist

- PASS: Removed duplicate center-column `TTS Studio` summary text.
- PASS: Removed duplicate left-column items that belong to Profile or Emotion Settings rows.
- PASS: Delivery values are owned by Emotion Settings through Pitch, Rate, and Volume fields.
- PASS: Preset value is owned by Emotion Settings through the Preset field.
- PASS: Removed right-column Output Summary.
- PASS: Voice Filters are owned by the Profile row dropdowns.
- PASS: Removed Named Sentence and queue UI.
- PASS: Removed related dead HTML, JavaScript, and test code for the stale queue/output controls.
- PASS: Message Studio child table uses the approved visible Message Parts columns.
- PASS: Theme V2 only; no local CSS or inline handlers/styles were added.

## Validation

- PASS: `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs`
- PASS: `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --trace=off`
- PASS: `node --test tests/tools/Text2SpeechShell.test.mjs`
- PASS: `npm run test:workspace-v2`
- PASS: `git diff --check`

`npm run test:workspace-v2` is a legacy command name; the user-facing product language remains Project Workspace and Game Hub.

## Notes

- The Text To Speech page still supports local preview playback through the shared engine audio module.
- Message Part display order remains persisted internally and is managed with Move Up and Move Down actions rather than a visible Order column.
15 changes: 5 additions & 10 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,10 @@ docs_build/dev/reports/playwright_discovery_ownership_report.md
docs_build/dev/reports/playwright_discovery_scope_report.md
docs_build/dev/reports/playwright_structure_audit.md
docs_build/dev/reports/playwright_v8_coverage_report.txt
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-instruction-compliance-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-manual-validation-notes.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-message-parent-child-table-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-tts-summary-layout-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-tts-tools-registration-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-validation-report.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction.md
docs_build/dev/reports/PR_26171_BETA_075-tts-message-table-cleanup-instruction-compliance-checklist.md
docs_build/dev/reports/PR_26171_BETA_075-tts-message-table-cleanup-manual-validation-notes.md
docs_build/dev/reports/PR_26171_BETA_075-tts-message-table-cleanup-validation-report.md
docs_build/dev/reports/PR_26171_BETA_075-tts-message-table-cleanup.md
docs_build/dev/reports/retry_suppression_report.md
docs_build/dev/reports/slow_path_pruning_report.md
docs_build/dev/reports/static_validation_report.md
Expand All @@ -38,11 +35,9 @@ docs_build/dev/reports/test_cleanup_routing_report.md
docs_build/dev/reports/testing_lane_execution_report.md
docs_build/dev/reports/validation_cache_report.md
docs_build/dev/reports/zero_browser_preflight_report.md
src/shared/toolbox/tool-metadata-inventory.js
tests/playwright/tools/MessagesTool.spec.mjs
tests/playwright/tools/RootToolsFutureState.spec.mjs
tests/playwright/tools/TextToSpeechFunctional.spec.mjs
tests/playwright/tools/ToolboxRoutePages.spec.mjs
toolbox/messages/index.html
toolbox/messages/messages.js
toolbox/text-to-speech/index.html
toolbox/text-to-speech/text2speech.js
Loading
Loading