Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 52 additions & 3 deletions docs_build/dev/PROJECT_INSTRUCTIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2009,7 +2009,9 @@ Rules:
- Do not ask the user if a branch should be pushed.
- Treat PR creation as required.
- Treat branch push as required.
- Treat merge as required after validation passes.
- Treat merge as required only after validation passes and explicit owner/EOD approval is provided.
- Local-only commits are prohibited as completed workstream state.
- Every completed PR scope must be committed and pushed before Codex continues to another PR.
- If GitHub prompts `Would you like to create a Pull Request?`, answer YES automatically.
- If merge conflicts occur:
- preserve latest main
Expand All @@ -2025,15 +2027,58 @@ Required Git workflow report fields:
- merge result
- final main commit

## GITHUB AUTHORITATIVE WORKSTREAM RULE

GitHub is the authoritative workstream record.

Rules:
- GitHub branches, commits, and pull requests are the authoritative record for active and completed Codex workstreams.
- Local-only commits are prohibited.
- A PR scope is not complete until its scoped changes are committed and pushed to GitHub.
- Every completed PR scope must be committed and pushed before Codex continues to another PR.
- Push failure is a hard stop until resolved.
- A branch ahead of origin is a hard stop because it contains unpushed commits.
- Detached HEAD execution is prohibited for PR work.
- Ownership mismatch is a hard stop.
- This rule does not authorize merging.
- EOD merge approval remains owner-controlled and requires explicit approval.

Start-gate sync validation:
- PASS when:
- current branch is not detached
- repository is clean
- current branch has an origin upstream
- `local == origin`
- local branch HEAD equals origin branch HEAD
- TEAM ownership matches the requested PR scope
- FAIL when:
- current branch is detached HEAD
- repository is dirty
- branch is ahead of origin
- branch has unpushed commits
- local branch HEAD does not equal origin branch HEAD
- push failure is unresolved
- TEAM ownership mismatches the requested PR scope

Required report output:
- current branch
- upstream branch
- local commit
- origin commit
- local/origin sync PASS/FAIL
- push result
- TEAM ownership PASS/FAIL

## OWNER-CONTROLLED STABLE AND MERGE APPROVAL

Stable promotion and merge approval are owner-controlled.

Rules:
- Codex may prepare scoped changes, reports, validation evidence, ZIP artifacts, branches, and PRs.
- Codex must not merge a PR or mark a workstream stable without explicit approval from the assigned Team Alpha or Team Beta owner.
- Codex must not merge a PR or mark a workstream stable without explicit approval from the assigned Team Alpha, Team Beta, or Team Gamma owner.
- Master Control may recommend sequencing or assignment, but affected workstream owners control stable and merge approval.
- This targeted section supersedes older automatic-merge wording when approval ownership is in question.
- EOD merge approval remains owner-controlled and requires explicit approval.

## CODEX INSTRUCTION ENFORCEMENT START GATE

Expand All @@ -2047,12 +2092,16 @@ Required instruction reads:

Required pre-change report:
- Codex must report instruction compliance as `PASS` or `FAIL` before making file changes.
- The report must include branch, clean status, PR TEAM owner, implementation path, validation scope, required report list, and ZIP requirement.
- The report must include branch, upstream branch, local/origin sync status, clean status, PR TEAM owner, implementation path, validation scope, required report list, and ZIP requirement.
- Any `FAIL` is a hard stop unless the PR explicitly scopes branch audit or recovery documentation without implementation.

Hard stops before changes:
- If the current branch is not `main`, HARD STOP.
- If the repository is not clean before the PR branch is created, HARD STOP.
- If the current branch is detached HEAD, HARD STOP.
- If local branch HEAD does not equal origin branch HEAD, HARD STOP.
- If the current branch is ahead of origin or has unpushed commits, HARD STOP.
- If a previous push failed and remains unresolved, HARD STOP.
- If the PR name does not include a required TEAM token, HARD STOP.
- If the PR TEAM owner does not match the team ownership map in `PROJECT_MULTI_PC.txt`, HARD STOP.
- If the PR asks for implementation and the implementation path is wrong, HARD STOP.
Expand Down
18 changes: 18 additions & 0 deletions docs_build/dev/PROJECT_MULTI_PC.txt
Original file line number Diff line number Diff line change
Expand Up @@ -524,13 +524,31 @@ Governance, recovery, diagnostics, and instruction-hardening PRs:
- Must document TEAM ownership compliance in the PR report.
- Recovery reports must include TEAM ownership.

GitHub Authoritative Workstream Rule:
- GitHub is the authoritative workstream record.
- GitHub branches, commits, and pull requests are the authoritative record for active and completed Codex workstreams.
- Local-only commits are prohibited.
- Every completed PR scope must be committed and pushed before Codex continues to another PR.
- Start-gate sync validation is PASS only when the branch is clean and `local == origin`, meaning local HEAD equals origin HEAD.
- Start-gate sync validation is FAIL when:
- branch is ahead of origin
- branch has unpushed commits
- current branch is detached HEAD
- push failure is unresolved
- TEAM ownership mismatches the requested PR scope
- Branch ahead of origin is a hard stop.
- Push failure is a hard stop until resolved.
- Ownership mismatch is a hard stop.
- EOD merge approval remains owner-controlled and requires explicit approval.

Stable and merge approval:
- Stable promotion and merge approval are controlled by the assigned Team Alpha, Team Beta, or Team Gamma owner.
- Master Control may recommend sequencing, but Codex must not merge or mark stable without explicit owner approval for the affected workstream.

Hard stop rules:
- If the PR name does not include a TEAM token, stop before changes.
- If the TEAM token does not match the owner map or explicit Master Control assignment, stop before changes.
- If branch sync validation fails, stop before changes.
- If the PR scope belongs to another TEAM owner, stop before changes.
- If the PR crosses multiple team ownership areas, stop and require Master Control to split or assign the work.
- If the requested implementation path conflicts with the active owner path, stop before changes.
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Instruction Compliance Checklist - PR_26171_GAMMA_009

- PR has one purpose only: PASS
- Exact PR name provided: PASS
- PR name includes TEAM token `GAMMA`: PASS
- Exact branch name provided: PASS
- Branch started from latest `main`: PASS
- `docs_build/dev/PROJECT_INSTRUCTIONS.md` read before changes: PASS
- `docs_build/dev/PROJECT_MULTI_PC.txt` read before changes: PASS
- Instruction enforcement start gate run before changes: PASS
- Repository clean before branch creation: PASS
- `main` local/origin sync verified before branch creation: PASS
- TEAM ownership verified as Gamma governance/instruction-hardening work: PASS
- Scope limited to requested governance docs: PASS
- GitHub authoritative workstream rule added: PASS
- Local-only commits prohibited: PASS
- Completed PR scopes require commit and push before continuing: PASS
- Start-gate sync validation added: PASS
- Branch ahead of origin hard stop added: PASS
- Owner-controlled EOD merge approval preserved: PASS
- Runtime code unchanged: PASS
- Required reports created: PASS
- Manual validation notes created: PASS
- ZIP required and pending final packaging: PASS
- Playwright skipped with reason documented: PASS
- Samples skipped with reason documented: PASS
- PR merge withheld until explicit EOD approval: PASS
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Manual Validation Notes - PR_26171_GAMMA_009

## Scope Review

Reviewed the governance docs after edit:
- `docs_build/dev/PROJECT_INSTRUCTIONS.md`
- `docs_build/dev/PROJECT_MULTI_PC.txt`

Confirmed:
- GitHub is declared as the authoritative workstream record.
- Local-only commits are prohibited.
- Completed PR scopes must be committed and pushed before continuing.
- Start-gate sync validation PASS requires a clean branch and `local == origin`.
- Start-gate sync validation FAIL includes branch ahead of origin, unpushed commits, detached HEAD, unresolved push failure, and ownership mismatch.
- Branch ahead of origin is a hard stop.
- Runtime code was not changed.
- EOD merge approval remains owner-controlled and requires explicit approval.

## Validation Notes

Static validation was sufficient because this PR updates governance documentation only.

Skipped lanes:
- Playwright was not run because no UI route, component, or browser behavior changed.
- Samples smoke was not run because samples are outside the requested docs/static validation scope.
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
# PR_26171_GAMMA_009-github-authoritative-workstream-sync

## Summary

This PR adds GitHub Authoritative Workstream governance to the project instructions.

Scope completed:
- Added `GitHub is the authoritative workstream record` to `PROJECT_INSTRUCTIONS.md`.
- Added matching GitHub authoritative workstream guidance to `PROJECT_MULTI_PC.txt`.
- Prohibited local-only commits as completed workstream state.
- Required every completed PR scope to be committed and pushed before continuing.
- Added start-gate sync validation PASS and FAIL criteria.
- Added hard stops for detached HEAD, local/origin mismatch, branch ahead of origin, unresolved push failure, and ownership mismatch.
- Preserved owner-controlled EOD merge approval.

## Start Gate

Instruction compliance start gate: PASS

- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`: PASS
- Read `docs_build/dev/PROJECT_MULTI_PC.txt`: PASS
- Checked out `main`: PASS
- Pulled latest `main`: PASS
- Verified current branch was `main` before creating PR branch: PASS
- Verified repository was clean before creating PR branch: PASS
- Verified `main` local/origin sync was `0 0`: PASS
- Created PR branch from `main`: PASS
- PR name includes TEAM token `GAMMA`: PASS
- TEAM ownership verified as Gamma governance/instruction-hardening scope: PASS
- Base `main` commit: `e8845dae6`

## Git Workflow

- PR branch: `pr/26171-GAMMA-009-github-authoritative-workstream-sync`
- Branch created from: `main`
- Branch push: PASS, pushed to `origin/pr/26171-GAMMA-009-github-authoritative-workstream-sync`
- Pull request: PASS, draft PR https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/34
- Merge status: not merged; EOD merge requires explicit owner approval
- ZIP artifact path: `tmp/PR_26171_GAMMA_009-github-authoritative-workstream-sync_delta.zip`

## Validation

Requested validation scope was docs/static only.

Executed:
- `git diff --check`: PASS
- Targeted text check verifying `GitHub is the authoritative workstream record` exists.
- Targeted text check verifying local-only commits are prohibited.
- Targeted text check verifying branch ahead of origin is a hard stop.
- Targeted text check verifying owner-controlled EOD merge approval remains enforced.

Skipped:
- Playwright: skipped by request; this PR modifies governance docs only.
- Samples smoke: skipped by request; this PR modifies governance docs only.

## Required Reports

- `docs_build/dev/reports/codex_review.diff`
- `docs_build/dev/reports/codex_changed_files.txt`
- `docs_build/dev/reports/PR_26171_GAMMA_009-github-authoritative-workstream-sync.md`
- `docs_build/dev/reports/PR_26171_GAMMA_009-github-authoritative-workstream-sync-manual-validation-notes.md`
- `docs_build/dev/reports/PR_26171_GAMMA_009-github-authoritative-workstream-sync-instruction-compliance-checklist.md`
56 changes: 8 additions & 48 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,48 +1,8 @@
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/codex_review.diff
docs_build/dev/reports/coverage_changed_js_guardrail.txt
docs_build/dev/reports/dependency_gating_report.md
docs_build/dev/reports/dependency_hydration_reuse_report.md
docs_build/dev/reports/execution_graph_reuse_report.md
docs_build/dev/reports/failure_fingerprint_report.md
docs_build/dev/reports/filesystem_scan_reduction_report.md
docs_build/dev/reports/incremental_validation_report.md
docs_build/dev/reports/lane_compilation_report.md
docs_build/dev/reports/lane_deduplication_report.md
docs_build/dev/reports/lane_input_validation_report.md
docs_build/dev/reports/lane_manifests/workspace-contract.json
docs_build/dev/reports/lane_runtime_optimization_report.md
docs_build/dev/reports/lane_snapshot_report.md
docs_build/dev/reports/lane_snapshots/workspace-contract.json
docs_build/dev/reports/lane_warm_start_report.md
docs_build/dev/reports/lane_warm_starts/workspace-contract.json
docs_build/dev/reports/monolith_trigger_removal_report.md
docs_build/dev/reports/persistent_lane_manifest_report.md
docs_build/dev/reports/playwright_discovery_ownership_report.md
docs_build/dev/reports/playwright_discovery_scope_report.md
docs_build/dev/reports/playwright_structure_audit.md
docs_build/dev/reports/playwright_v8_coverage_report.txt
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-instruction-compliance-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-manual-validation-notes.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-message-parent-child-table-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-tts-summary-layout-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-tts-tools-registration-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-validation-report.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction.md
docs_build/dev/reports/retry_suppression_report.md
docs_build/dev/reports/slow_path_pruning_report.md
docs_build/dev/reports/static_validation_report.md
docs_build/dev/reports/targeted_file_manifest_report.md
docs_build/dev/reports/test_cleanup_performance_report.md
docs_build/dev/reports/test_cleanup_routing_report.md
docs_build/dev/reports/testing_lane_execution_report.md
docs_build/dev/reports/validation_cache_report.md
docs_build/dev/reports/zero_browser_preflight_report.md
src/shared/toolbox/tool-metadata-inventory.js
tests/playwright/tools/MessagesTool.spec.mjs
tests/playwright/tools/RootToolsFutureState.spec.mjs
tests/playwright/tools/TextToSpeechFunctional.spec.mjs
tests/playwright/tools/ToolboxRoutePages.spec.mjs
toolbox/messages/index.html
toolbox/messages/messages.js
toolbox/text-to-speech/index.html
M docs_build/dev/reports/PR_26171_GAMMA_009-github-authoritative-workstream-sync.md

docs_build/dev/PROJECT_INSTRUCTIONS.md | 55 +++++++++++++++++--
docs_build/dev/PROJECT_MULTI_PC.txt | 18 +++++++
...stream-sync-instruction-compliance-checklist.md | 27 ++++++++++
...tive-workstream-sync-manual-validation-notes.md | 25 +++++++++
...MMA_009-github-authoritative-workstream-sync.md | 62 ++++++++++++++++++++++
5 files changed, 184 insertions(+), 3 deletions(-)
Loading