Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# PR_26171_BETA_073-message-tts-table-ui-correction Instruction Compliance Checklist

Generated: 2026-06-20T23:06:25.711Z
Team ownership: BETA
Branch: pr/26171-BETA-073-message-tts-table-ui-correction

## Gate

- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
- PASS: Read `docs_build/dev/PROJECT_MULTI_PC.txt`.
- PASS: Current branch was `main` before creating `pr/26171-BETA-073-message-tts-table-ui-correction`.
- PASS: Repository was clean and synced with `origin/main` before branch creation.
- PASS: PR name includes required TEAM token `BETA`.
- PASS: Team BETA owns Messages, Text To Speech/TTS, and Audio content work.
- PASS: Implementation path uses active `toolbox/text-to-speech/` and `toolbox/messages/` paths.
- PASS: No `tools/text2speech/` path was created.
- PASS: Required validation scope was targeted TTS Studio, targeted Message Studio, and legacy `npm run test:workspace-v2` for Project Workspace/Game Hub coverage.
- PASS: Required report and ZIP outputs are included in this PR.
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# PR_26171_BETA_073-message-tts-table-ui-correction Manual Validation Notes

Generated: 2026-06-20T23:06:25.711Z
Team ownership: BETA
Branch: pr/26171-BETA-073-message-tts-table-ui-correction

## Manual Review

- Reviewed `src/shared/toolbox/tool-metadata-inventory.js` to confirm Text To Speech uses the active `text-to-speech/index.html` registry entry and beta release metadata.
- Reviewed `toolbox/text-to-speech/index.html` to confirm the summary uses only Theme V2 reusable classes and keeps all live data hooks.
- Reviewed `toolbox/messages/index.html` and `toolbox/messages/messages.js` to confirm Add Message/Add Part are table-row workflows and Message Parts remain child table content.
- Reviewed targeted Playwright coverage for Message Studio TTS Profile dropdown compatibility.

## Automated Browser Validation Used As Manual Proxy

- TTS validation clicked through the toolbox index Text To Speech card and confirmed the active path.
- TTS validation exercised the TTS Studio page, summary hooks, profile/emotion table behavior, and speech synthesis.
- Message validation exercised add/edit message rows, add/edit part rows, name-cell expansion, part-count non-expansion, message playback, part playback, and unavailable audio errors.

## Not Performed

- No unscripted manual browser session was run beyond Playwright browser validation.
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# PR_26171_BETA_073-message-tts-table-ui-correction Message Parent-Child Table Checklist

Generated: 2026-06-20T23:06:25.711Z
Team ownership: BETA

- PASS: Parent table remains `Messages`.
- PASS: Message name cell owns expand/collapse and exposes `aria-expanded`.
- PASS: Keyboard Enter/Space on the message name cell toggles the child table.
- PASS: Clicking the Parts count cell does not expand the child table.
- PASS: Child table remains `Message Parts` with ordered parts.
- PASS: Child table includes Order, Text, Emotion, TTS Profile, Status, and Actions columns.
- PASS: Add Message is an inline table action row and opens an inline add row.
- PASS: Edit Message opens an inline edit row.
- PASS: Add Part is an inline child-table action row and opens an inline add row.
- PASS: Edit Part opens an inline edit row.
- PASS: Play Message, Play Part, and Stop remain visible and validated.
- PASS: No separate Emotion Studio was introduced.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# PR_26171_BETA_073-message-tts-table-ui-correction TTS Summary Layout Checklist

Generated: 2026-06-20T23:06:25.711Z
Team ownership: BETA

- PASS: TTS summary uses existing Theme V2 `content-cluster content-cluster--nowrap` classes.
- PASS: TTS summary uses existing `pill`, `mini-stat`, and `mini-stat--inline` classes.
- PASS: Summary row includes TTS Studio, Characters, TTS Profiles, Emotion Settings, Voices, and Engine items.
- PASS: The existing live data hooks remain: `data-tts-text-count`, `data-tts-profile-count`, `data-tts-emotion-count`, `data-tts-voice-count`, and `data-tts-engine-label`.
- PASS: No page-local CSS, tool-local CSS, inline style, or style block was added.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# PR_26171_BETA_073-message-tts-table-ui-correction TTS Tools Registration Checklist

Generated: 2026-06-20T23:06:25.711Z
Team ownership: BETA

- PASS: Text To Speech metadata uses `path: text-to-speech`.
- PASS: Text To Speech metadata uses `entryPoint: text-to-speech/index.html`.
- PASS: Text To Speech metadata now uses `status: beta` and `releaseChannel: beta`.
- PASS: Toolbox index validation finds `Text To Speech` with href `/toolbox/text-to-speech/index.html`.
- PASS: Toolbox index validation finds `data-registered-tool-route=toolbox/text-to-speech/index.html`.
- PASS: Validation asserts no link targets `tools/text2speech`.
- PASS: No `tools/text2speech/` directory was created.
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# PR_26171_BETA_073-message-tts-table-ui-correction Validation Report

Generated: 2026-06-20T23:06:25.711Z
Team ownership: BETA
Branch: pr/26171-BETA-073-message-tts-table-ui-correction

## Required Validation

- PASS: `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs`
- 3 passed. Covers TTS page behavior, one-line summary row, toolbox registration path, and unavailable speech error.
- PASS: `node --test tests/tools/Text2SpeechShell.test.mjs`
- 4 passed. Covers TTS shell/profile contract.
- PASS: `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --trace=off`
- 2 passed. Covers Messages parent/child table, inline add/edit rows, TTS Profile dropdown compatibility, playback, and unavailable audio error.
- PASS: `npm run test:workspace-v2`
- Legacy command name; user-facing product language is Project Workspace/Game Hub. Final rerun passed 5 workspace-contract tests.
- PASS: `git diff --check`
- No whitespace errors; Git emitted line-ending normalization warnings only.

## Additional Focused Sanity Validation

- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox index shows wireframe" --trace=off`
- 1 passed after updating expected toolbox counts for Text To Speech moving from planned/missing metadata into active beta registration.

## Notes

- Initial Message Studio validation exposed a missing Add Message control on empty tables; fixed and reran to PASS.
- Initial Project Workspace validation exposed stale toolbox count expectations; fixed and reran to PASS.
- Node emitted experimental SQLite warnings during relevant test runs; tests passed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# PR_26171_BETA_073-message-tts-table-ui-correction

Generated: 2026-06-20T23:06:25.711Z
Team ownership: BETA
Branch: pr/26171-BETA-073-message-tts-table-ui-correction
Base HEAD: eaee83f9327b336ec5679ebd591d94e50fab0523
origin/main at branch start: eaee83f9327b336ec5679ebd591d94e50fab0523
Ahead/behind before commit: 0 0
Spec source: latest user request in Codex session; no repository BUILD_PR doc for PR_26171_BETA_073 was found by targeted search.

## Purpose

Correct TTS and Message Studio UI alignment while preserving Theme V2, external JavaScript, existing Local API contracts, and server/API-backed product data ownership.

## Requirement Checklist

- PASS: TTS Studio appears on the toolbox index through the active registry path `toolbox/text-to-speech/index.html`.
- PASS: No `tools/text2speech/` path was created or linked.
- PASS: TTS summary uses a single Theme V2 inline row with TTS Studio, Characters, TTS Profiles, Emotion Settings, Voices, and Engine items.
- PASS: Message Studio keeps parent table `Messages`.
- PASS: Message name cell owns expand/collapse for the Message Parts child table; clicking the Parts count does not expand.
- PASS: Message Parts child table keeps ordered parts with Text, Emotion, TTS Profile, Status, and Actions.
- PASS: Add/Edit Message and Add/Edit Part remain inline row workflows.
- PASS: Play Message, Play Part, and Stop controls remain visible and validated.
- PASS: No separate Emotion Studio was created.
- PASS: No database tables or browser-owned product data source of truth were added.
- PASS: No inline styles, style blocks, inline event handlers, page-local CSS, or tool-local CSS were added.

## Implementation Summary

- Corrected Text To Speech registry metadata from uppercase `Beta` to authoritative `beta` release-channel metadata so the DB-backed toolbox registry exposes it as active/visible.
- Reworked the TTS summary from a five-card grid into a Theme V2 nowrap inline summary row.
- Moved Message Studio Add Message and Add Part actions into table rows.
- Tightened Message Studio expansion to the parent message name cell with keyboard support.
- Updated targeted and workspace tests for the corrected TTS registration and table behavior.

## Git Workflow

- Current branch: pr/26171-BETA-073-message-tts-table-ui-correction
- Created branch: `pr/26171-BETA-073-message-tts-table-ui-correction`
- Push result: pending until commit/push step completes.
- PR URL: pending until PR creation step completes.
- Merge result: pending until PR merge step completes.
- Final main commit: pending until post-merge sync completes.
21 changes: 17 additions & 4 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table-manual-validation-notes.md
docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table-validation.md
docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table.md
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/codex_review.diff
docs_build/dev/reports/coverage_changed_js_guardrail.txt
Expand All @@ -13,15 +10,25 @@ docs_build/dev/reports/incremental_validation_report.md
docs_build/dev/reports/lane_compilation_report.md
docs_build/dev/reports/lane_deduplication_report.md
docs_build/dev/reports/lane_input_validation_report.md
docs_build/dev/reports/lane_manifests/workspace-contract.json
docs_build/dev/reports/lane_runtime_optimization_report.md
docs_build/dev/reports/lane_snapshot_report.md
docs_build/dev/reports/lane_snapshots/workspace-contract.json
docs_build/dev/reports/lane_warm_start_report.md
docs_build/dev/reports/lane_warm_starts/workspace-contract.json
docs_build/dev/reports/monolith_trigger_removal_report.md
docs_build/dev/reports/persistent_lane_manifest_report.md
docs_build/dev/reports/playwright_discovery_ownership_report.md
docs_build/dev/reports/playwright_discovery_scope_report.md
docs_build/dev/reports/playwright_structure_audit.md
docs_build/dev/reports/playwright_v8_coverage_report.txt
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-instruction-compliance-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-manual-validation-notes.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-message-parent-child-table-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-tts-summary-layout-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-tts-tools-registration-checklist.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction-validation-report.md
docs_build/dev/reports/PR_26171_BETA_073-message-tts-table-ui-correction.md
docs_build/dev/reports/retry_suppression_report.md
docs_build/dev/reports/slow_path_pruning_report.md
docs_build/dev/reports/static_validation_report.md
Expand All @@ -31,5 +38,11 @@ docs_build/dev/reports/test_cleanup_routing_report.md
docs_build/dev/reports/testing_lane_execution_report.md
docs_build/dev/reports/validation_cache_report.md
docs_build/dev/reports/zero_browser_preflight_report.md
src/shared/toolbox/tool-metadata-inventory.js
tests/playwright/tools/MessagesTool.spec.mjs
tests/playwright/tools/RootToolsFutureState.spec.mjs
tests/playwright/tools/TextToSpeechFunctional.spec.mjs
toolbox/text-to-speech/text2speech.js
tests/playwright/tools/ToolboxRoutePages.spec.mjs
toolbox/messages/index.html
toolbox/messages/messages.js
toolbox/text-to-speech/index.html
Loading
Loading