Skip to content

PR_26171_BETA_069 message tts profile contract alignment#25

Merged
ToolboxAid merged 1 commit into
mainfrom
pr/26171-BETA-069-message-tts-profile-contract-alignment
Jun 20, 2026
Merged

PR_26171_BETA_069 message tts profile contract alignment#25
ToolboxAid merged 1 commit into
mainfrom
pr/26171-BETA-069-message-tts-profile-contract-alignment

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Aligns Message Studio visible contract wording to Message Parts choosing Text, Emotion, and TTS Profile.
  • Renames the Local API default TTS profile seed to the required Default Balanced TTS Profile.
  • Tightens Message Studio validation coverage for the Message Part add/edit row Text, Emotion, and TTS Profile controls.
  • Includes BETA ownership, parent/child table, validation, manual notes, review diff, changed files, and generated validation lane reports.

TEAM Ownership

  • TEAM owner: BETA
  • Message Studio: BETA-owned Messages
  • TTS Studio: BETA-owned Text To Speech / TTS
  • TextToSpeechEngine-adjacent playback: BETA-owned Audio/TTS lane, with src/engine/audio retaining playback implementation ownership

Validation

  • npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --trace=off
  • npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs
  • node --test tests/tools/Text2SpeechShell.test.mjs
  • npm run test:workspace-v2
  • git diff --check

Note: npm run test:workspace-v2 is a legacy command name; user-facing language remains Project Workspace / Game Hub.

Reports

  • docs_build/dev/reports/PR_26171_BETA_069-message-tts-profile-contract-alignment.md
  • docs_build/dev/reports/PR_26171_BETA_069-message-tts-profile-contract-alignment-message-tts-ownership-checklist.md
  • docs_build/dev/reports/PR_26171_BETA_069-message-tts-profile-contract-alignment-parent-child-table-checklist.md
  • docs_build/dev/reports/PR_26171_BETA_069-message-tts-profile-contract-alignment-validation.md
  • docs_build/dev/reports/PR_26171_BETA_069-message-tts-profile-contract-alignment-manual-validation-notes.md
  • docs_build/dev/reports/codex_review.diff
  • docs_build/dev/reports/codex_changed_files.txt

ZIP

  • tmp/PR_26171_BETA_069-message-tts-profile-contract-alignment_delta.zip

@ToolboxAid ToolboxAid merged commit 78b642f into main Jun 20, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06b262d25e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

description: "Balanced local browser playback option until authored TTS profiles are available.",
language: "en-US",
name: "Browser Speech Default",
name: "Default Balanced TTS Profile",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Migrate the old TTS seed name instead of duplicating it

In an existing Messages SQLite database created before this commit, changing the seed name here causes seedDefaults() to miss the previous Browser Speech Default row because it only checks findTtsProfileByName(profile.name), then inserts a second active default profile. Since listTtsProfiles() orders by name and Message Studio chooses the first active TTS profile as the default, those existing databases will keep using/displaying Browser Speech Default ahead of the new balanced profile rather than aligning to the new contract. Add a migration/rename path for the old seed instead of treating the new label as a separate seed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants