Skip to content

PR_26179_OWNER_007-move-reports-artifacts#242

Merged
ToolboxAid merged 2 commits into
mainfrom
PR_26179_OWNER_007-move-reports-artifacts
Jun 27, 2026
Merged

PR_26179_OWNER_007-move-reports-artifacts#242
ToolboxAid merged 2 commits into
mainfrom
PR_26179_OWNER_007-move-reports-artifacts

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

PR_26179_OWNER_007-move-reports-artifacts

Generated: 2026-06-27T19:33:15.325Z
Branch: PR_26179_OWNER_007-move-reports-artifacts
Base stack head before PR_007: 119fa88
ZIP: dev/workspace/artifacts/tmp/PR_26179_OWNER_007-move-reports-artifacts_delta.zip

Purpose

Move generated report and artifact ownership to the new dev workspace locations while keeping runtime/product code untouched.

Changes

  • Moved tracked generated reports from dev/docs_build/dev/reports/ to flat dev/reports/.
  • Added dev/workspace/artifacts/ ownership documentation for non-report generated artifacts.
  • Updated Codex/PR/reporting governance to require flat dev/reports/ and ZIPs under dev/workspace/artifacts/tmp/.
  • Updated dev script defaults, Playwright output, report writers, and report-related tests to the new paths.

Report Inventory

  • Old tracked report path count: 0
  • New tracked flat report count: 3578
  • Nested tracked paths under dev/reports/: 0

Validation Summary

Status Item Notes
PASS Current branch is PR_26179_OWNER_007-move-reports-artifacts confirmed
PASS No product/runtime/API/database files changed git diff against production/runtime scopes returned no files
PASS Tracked reports moved out of dev/docs_build/dev/reports 0 tracked files remain in old report tree
PASS Tracked reports are flat under dev/reports 3578 tracked report files, 0 nested report paths
PASS Generated ZIP/report/artifact expectations updated active instructions and helper defaults use dev/reports and dev/workspace/artifacts
PASS git diff --check passed
PASS node --check on changed JS/MJS files passed
PASS npm run test:audit:locations passed
PASS npm run validate:canonical-structure passed
PASS Playwright config list npx playwright test --config=dev/config/playwright.config.cjs --list passed
WARN Legacy workspace migration validation ProjectWorkspaceMigrationGovernanceCloseoutValidation.test.mjs cannot load a pre-existing missing toolbox/workspace-manager-v2 module; not expanded in this reports/artifacts PR

…ve-reports-artifacts

# Conflicts:
#	dev/docs_build/dev/reports/codex_changed_files.txt
#	dev/docs_build/dev/reports/codex_review.diff
@ToolboxAid ToolboxAid changed the base branch from PR_26179_OWNER_006-move-bootstrap-scripts to main June 27, 2026 21:12
@ToolboxAid ToolboxAid marked this pull request as ready for review June 27, 2026 21:13
@ToolboxAid ToolboxAid merged commit 17600f9 into main Jun 27, 2026
2 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

const reportsDirectory = resolve(repoRoot, "dev", "reports");

P2 Badge Update the codex review artifact consumer

When codex:review-artifacts writes to this new directory, dev/tests/playwright/tools/AssetToolMockRepository.spec.mjs still resolves dev/docs_build/dev/reports/codex_review.diff, and this commit deletes that old file while adding dev/reports/codex_review.diff. Running the asset-tool Playwright test after a clean checkout will hit expect(existsSync(reviewDiffPath)).toBe(true) against a missing path, so update the test/consumer along with the writer.


log('installing isolated dependency: ws -> <project>/dev/workspace/artifacts/tmp/node_modules');

P2 Badge Move launch-smoke outputs, not just messages

For npm run test:launch-smoke, this message now advertises dev/workspace/artifacts/tmp, but the script still sets tmpRoot to <repo>/tmp and still sets reportsDir to dev/docs_build/dev/reports. Running the smoke test will therefore continue installing ws and writing browser/runtime artifacts under the old root tmp, and it will recreate the deleted reports tree instead of writing dev/reports/launch_smoke_report.md, which breaks the new report/artifact ownership contract for this workflow.


const defaultLaneSnapshotDir = "dev/workspace/artifacts/lane_snapshots";

P2 Badge Reuse the moved lane snapshots from the new layout

The commit adds the existing lane snapshot/manifest/warm-start JSON as flattened dev/reports/lane_*__*.json files, but this default now makes the runner look for dev/workspace/artifacts/lane_snapshots/<lane>.json. On a fresh checkout none of those workspace paths exist, so run-targeted-test-lanes.mjs treats every tracked snapshot as missing, regenerates untracked workspace files, and the committed flattened snapshots are never consumed for reuse/incremental validation.


log("installing isolated dependency: ws -> <project>/dev/workspace/artifacts/tmp/node_modules");

P2 Badge Move workspace-manager temp output with the message

When this workspace-manager smoke test is run directly, the new log text says the isolated dependency lives under dev/workspace/artifacts/tmp, but the test still defines tmpRoot as <repo>/tmp, so npm install --prefix, workspace-manager-open-test-results.json, and the browser profile continue to be written under the old root. This leaves the workflow violating the new artifact location while reporting the opposite path to the operator.



P2 Badge Update the remaining report writers

With dev/reports/ now declared as the generated-report owner, active report writers still point at the deleted dev/docs_build/dev/reports tree: npm run validate:browser-env-agnostic writes environment_agnostic_browser_gate_report.md there, and dev/scripts/audit-duplicate-file-content.mjs writes both duplicate-audit reports there. Running either script after this relocation recreates the old report directory and leaves the moved dev/reports copies stale.


ZIP artifacts must be written under:
```text
dev/workspace/artifacts/tmp/

P2 Badge Align the root agent instructions with the new ZIP path

This new standard says ZIPs must go under dev/workspace/artifacts/tmp/, but the active root AGENTS.md still instructs every BUILD to output <project folder>/tmp/<TASK_NAME>_delta.zip and not stage ZIPs from <project folder>/tmp/. Because agents read that root instruction for this repo, future BUILDs will keep producing ZIPs in the old location unless the top-level instruction is updated with this change.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants