PR_26171_069 message TTS profile contract alignment#23
Conversation
…ssage-tts-profile-contract-alignment # Conflicts: # docs_build/dev/reports/codex_changed_files.txt # docs_build/dev/reports/codex_review.diff
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98b8d0e9d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| createTextToSpeechProfileEmotion({ emotion: "happy", pitch: 1.08, rate: 1.04 }), | ||
| createTextToSpeechProfileEmotion({ emotion: "angry", pitch: 0.96, rate: 1.08, volume: 1 }), | ||
| createTextToSpeechProfileEmotion({ emotion: "scared", pitch: 1.12, rate: 1.12, volume: 0.9 }), |
There was a problem hiding this comment.
Adding the profile-owned Happy/Angry/Scared settings here does not make them usable by Message Studio: the message tool still loads separate /messages/emotion-profiles records and speakTarget() applies target.emotionProfile.pitch/rate/volume instead of looking up the selected TTS profile's emotionSettings. As a result, any Message Part intended to use these new per-profile settings (notably Happy or Scared, which are not in the message emotion seed data) cannot select or play with them, so the TTS-profile emotion contract is only reflected in TTS Studio output, not in Message playback.
Useful? React with 👍 / 👎.
2 participants
Summary
TextToSpeechEngine.stop().Validation
node --check toolbox/messages/messages.jsnode --check toolbox/messages/message-tts-service-registry.jsnode --check toolbox/text-to-speech/text2speech.jsnode --check tests/playwright/tools/MessagesTool.spec.mjsnode --check tests/playwright/tools/TextToSpeechFunctional.spec.mjsnode --check tests/tools/Text2SpeechShell.test.mjsnode --test tests/tools/Text2SpeechShell.test.mjsnpx playwright test tests/playwright/tools/MessagesTool.spec.mjs tests/playwright/tools/TextToSpeechFunctional.spec.mjs --project=playwright --workers=1 --reporter=listnpm run test:workspace-v2(legacy command name; Project Workspace validation)ZIP
tmp/PR_26171_069-message-tts-profile-contract-alignment_delta.zip