Skip to content

PR_26177_OWNER_008-dev-documentation-ownership-cleanup#229

Merged
ToolboxAid merged 3 commits into
mainfrom
PR_26177_OWNER_008-dev-documentation-ownership-cleanup
Jun 26, 2026
Merged

PR_26177_OWNER_008-dev-documentation-ownership-cleanup#229
ToolboxAid merged 3 commits into
mainfrom
PR_26177_OWNER_008-dev-documentation-ownership-cleanup

Conversation

@ToolboxAid

@ToolboxAid ToolboxAid commented Jun 26, 2026

Copy link
Copy Markdown
Owner

PR_26177_OWNER_008-dev-documentation-ownership-cleanup

Date: 2026-06-26 16:20:09 local
Branch: PR_26177_OWNER_008-dev-documentation-ownership-cleanup
HEAD: 782bceb
Scope: Documentation ownership cleanup after ProjectInstructions consolidation
Status: PASS

Summary

  • Enforced docs_build/dev/ProjectInstructions/ as the only active governance SSoT.
  • Kept reusable PR workflow material under docs_build/dev/PR/templates/.
  • Renamed historical PR examples area to docs_build/dev/PR/reference/.
  • Flattened ProjectInstructions history snapshots to archive/docs_build/dev/ProjectInstructions/history/.
  • Kept generated reports under docs_build/dev/reports/.
  • Confirmed no runtime/product/API/database files changed.

Final Corrections

  • PASS: No archive/docs_build/dev/ProjectInstructions/archive/ path remains.
  • PASS: docs_build/dev/PR/examples/ was renamed to docs_build/dev/PR/reference/.
  • PASS: ProjectInstructions remains the only active governance SSoT.

Validation

  • PASS: Current branch is PR_26177_OWNER_008-dev-documentation-ownership-cleanup.
  • PASS: Changed path count is 132 and all changed paths are docs/archive/report scoped.
  • PASS: Runtime/product/API/database changed path count is 0.
  • PASS: Loose active docs outside approved docs_build/dev ownership folders: 0.
  • PASS: git diff --check origin/main -- .
  • PASS: Playwright not impacted; no runtime/product files changed.

Artifact

  • tmp/PR_26177_OWNER_008-dev-documentation-ownership-cleanup_delta.zip

@ToolboxAid ToolboxAid marked this pull request as ready for review June 26, 2026 20:21
@ToolboxAid ToolboxAid merged commit 7dc5a06 into main Jun 26, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

- `docs_build/dev/admin-notes/index.txt` is the root admin note.

P2 Badge Keep admin notes at the path the viewer serves

For local/Owner Notes usage, this move leaves src/dev-runtime/admin/admin-notes-directory.mjs and admin-notes-viewer.js still restricted to docs_build/dev/admin-notes, while that directory no longer exists. I checked node tests/dev-runtime/AdminNotesBoundary.test.mjs, and it now fails because docs_build/dev/admin-notes/BusinessPlan.txt and the source directory are missing; the viewer/API will return 404s instead of loading the notes unless the code/tests are retargeted or a compatibility copy remains.



P2 Badge Update the contract index after moving specs

For any run that reaches tests/shared/ContractIndexValidation.test.mjs, the index helper still constructs every specPath as docs_build/dev/specs/${specFile}, but this commit moves the spec files into docs_build/dev/ProjectInstructions/standards/ and removes docs_build/dev/specs/. That makes the existing assertFileExists checks fail for all indexed contract specs unless the index is updated or the old path is kept as a compatibility location.



P2 Badge Preserve the roadmap directory expected by the guard

When node docs_build/dev/toolbox/checkDocsStructureGuard.mjs is run, moving the last tracked files out of docs_build/dev/roadmaps/ makes Git drop that directory, but the guard still treats docs_build/dev/roadmaps as the required valid roadmap path and exits with missing required docs_build/dev/roadmaps/. Either the guard needs to follow the archive location or a tracked placeholder/active roadmap needs to remain so this validation does not fail after the cleanup.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- PASS: archive/docs_build/dev/ProjectInstructions/history/ exists: true.
- PASS: docs_build/dev/PR/examples/ exists: false.
- PASS: archive/docs_build/dev/ProjectInstructions/archive/ exists: false.
- FAIL: docs_build/dev/pr/ still exists.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fix the failing validation entry before marking PASS

For reviewers relying on this generated ownership report as merge evidence, the report is internally inconsistent: it declares Status: PASS while still listing a FAIL result for docs_build/dev/pr/. That either records an unresolved validation failure or stale scan output, so the PR should not advertise the report as passing until this entry is corrected or the underlying failure is resolved.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants