Skip to content

PR_26177_OWNER_007-project-instructions-single-source-eod-lock#218

Merged
ToolboxAid merged 10 commits into
mainfrom
PR_26177_OWNER_007-project-instructions-single-source-eod-lock
Jun 26, 2026
Merged

PR_26177_OWNER_007-project-instructions-single-source-eod-lock#218
ToolboxAid merged 10 commits into
mainfrom
PR_26177_OWNER_007-project-instructions-single-source-eod-lock

Conversation

@ToolboxAid

@ToolboxAid ToolboxAid commented Jun 26, 2026

Copy link
Copy Markdown
Owner

PR_26177_OWNER_007-project-instructions-single-source-eod-lock

Date: 2026-06-26
Branch: PR_26177_OWNER_007-project-instructions-single-source-eod-lock
Scope: Project Instructions single-source governance, EOD main lock, branch lifecycle governance, docs_build/dev root cleanup, Tool MVP stacked PR governance, no-mock runtime source governance, and legacy docs archiving
Status: PASS

Summary

  • Established docs_build/dev/ProjectInstructions/ as the only active Project Instructions source.
  • Added canonical Branch Lifecycle governance: START, WORK, END.
  • Documented START, WORK, END branch lifecycle and mandatory hard stops.
  • Deleted duplicate active instruction files from docs_build/dev root.
  • Deleted stale one-off PR/restart files listed by OWNER review from docs_build/dev root.
  • Added docs_build/dev/pr/ and moved PR-specific root docs there, including this PR's PLAN_PR.md and BUILD_PR.md.
  • Moved active governance/contract root docs into docs_build/dev/ProjectInstructions/addendums/.
  • Moved audit outputs into docs_build/dev/reports/audits/.
  • Deleted stale one-off bundle metadata from docs_build/dev root.
  • Added docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md.
  • Added docs_build/dev/ProjectInstructions/addendums/no_mock_repository_runtime_source.md.
  • Updated Creator-testable stacked MVP governance so PR outcomes cannot be complete when visible data comes from mock repositories, page arrays, JSON source files, browser storage, or /tmp.
  • Moved verified old/superseded DoD and roadmap docs to the existing root archive tree under archive/docs_build/dev/.
  • Updated active preservation guidance so future archive/history material uses the root archive tree.
  • Added docs_build/dev/reports/legacy-docs-archive-report.md.
  • Updated the PR branch against latest origin/main for OWNER EOD; conflicts were limited to generated Codex report files and were resolved by regeneration.
  • Confirmed no docs_build/dev/archive/ folder was created.
  • Confirmed no new docs_build/dev/ProjectInstructions/archive/ path was created.
  • Corrected project-instructions/** scope so the PR only adds a tiny deprecated pointer README there.
  • Preserved project-instructions/addendums/** unchanged in the PR; unique current governance content is carried by docs_build/dev/ProjectInstructions/addendums/.
  • No product/runtime, start_of_day, feature, or legacy SQLite file changes were made.

Legacy Docs Archived

Moved verified old/superseded DoD material:

  • docs_build/dev/dod/tool_ui_readiness_dod.md -> archive/docs_build/dev/dod/tool_ui_readiness_dod.md

Moved verified old/superseded roadmap material:

  • docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE.md -> archive/docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE.md
  • docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_APPEND.md -> archive/docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_APPEND.md
  • docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_UPDATE.md -> archive/docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_UPDATE.md
  • docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_UPDATE_8_19.md -> archive/docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_UPDATE_8_19.md
  • docs_build/dev/roadmaps/MASTER_ROADMAP_RECOVERY.md -> archive/docs_build/dev/roadmaps/MASTER_ROADMAP_RECOVERY.md
  • docs_build/dev/roadmaps/MASTER_ROADMAP_SAMPLES2TOOLS.md -> archive/docs_build/dev/roadmaps/MASTER_ROADMAP_SAMPLES2TOOLS.md
  • docs_build/dev/roadmaps/MASTER_ROADMAP_TOOLS.md -> archive/docs_build/dev/roadmaps/MASTER_ROADMAP_TOOLS.md
  • docs_build/dev/roadmaps/MIDI_STUDIO_V2_ROADMAP.md -> archive/docs_build/dev/roadmaps/MIDI_STUDIO_V2_ROADMAP.md
  • docs_build/dev/roadmaps/phases.txt -> archive/docs_build/dev/roadmaps/phases.txt
  • docs_build/dev/roadmaps/README.md -> archive/docs_build/dev/roadmaps/README.md

Folders:

  • docs_build/dev/dod/ removed because it was empty after the move.
  • docs_build/dev/roadmaps/ retained because unlisted roadmap files remain there.

No Mock Repository Runtime Source

Added governance:

  • Required product-data flow: Browser → API → Database.
  • Mock repositories are 100% technical debt.
  • "Mock repository ready" is not a valid Creator-testable completion state.
  • Page arrays, JSON source files, /tmp files, and browser storage are not product-data sources of truth.
  • Runtime tool data must come from the API/service contract backed by the database.
  • Seed data is allowed only if it seeds the database.
  • Seed execution must be owned by server/API/setup flow.
  • Browser pages must not seed authoritative records directly.
  • Temporary mock repositories must document why they exist, affected files, removal PR, replacement API/DB path, and Creator-testable limitation.
  • "Game Configuration mock repository ready" does not count as complete; completion requires Game Configuration data to load through Browser → API → Database.

Validation

  • PASS: current branch is PR_26177_OWNER_007-project-instructions-single-source-eod-lock.
  • PASS: targeted path checks confirm requested legacy docs moved to archive/docs_build/dev/dod/ and archive/docs_build/dev/roadmaps/.
  • PASS: docs_build/dev/dod/ removed after becoming empty.
  • PASS: docs_build/dev/roadmaps/ retained because unlisted roadmap files remain.
  • PASS: docs_build/dev/archive/ was not created.
  • PASS: no new docs_build/dev/ProjectInstructions/archive/ path was created in this PR.
  • PASS: active preservation guidance points to archive/docs_build/dev/ProjectInstructions/history/.
  • PASS: legacy-docs-archive-report.md exists and confirms active governance remains only in docs_build/dev/ProjectInstructions/.
  • PASS: latest origin/main was merged into the PR branch for EOD; conflicts were limited to codex_changed_files.txt and codex_review.diff.
  • PASS: project-instructions/** PR diff is limited to project-instructions/README.md.
  • PASS: Tool MVP Stacked PR Standard exists and includes required governance text.
  • PASS: No Mock Repository Runtime Source exists and includes required governance text.
  • PASS: targeted grep found no active duplicate ProjectInstructions source-of-truth claim outside the active source.
  • PASS: product/runtime and start_of_day changed-file check returned no files.
  • PASS: git diff --check.
  • PASS: Playwright not run because this PR changes documentation/governance only.

Artifact

  • tmp/PR_26177_OWNER_007-project-instructions-single-source-eod-lock_delta.zip

@ToolboxAid ToolboxAid marked this pull request as ready for review June 26, 2026 19:45
@ToolboxAid ToolboxAid merged commit c8c2cc2 into main Jun 26, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 174c3407e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- `docs_build/dev/bundle_readme.md` (delete)
- `docs_build/dev/validation_checklist.txt` (delete)
- `docs_build/dev/dod/tool_ui_readiness_dod.md` (move to root archive)
- `docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE.md` (move to root archive)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore or retarget active roadmap consumers

Moving docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE.md to the archive leaves active repo consumers pointing at the deleted path. I checked the published npm script check:phase24-closeout-guard, which reads docs_build/dev/toolbox/checkPhase24CloseoutExecutionGuard.baseline.json, and it now exits with Roadmap path missing: docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE.md; the top-level README and docs_build/operations/dev/ROADMAP_GUARDRAILS.md also still treat this path as the active roadmap. Any local/CI closeout validation or onboarding link that uses those active references will fail until the guard/docs are updated to the new path or the roadmap remains in its active location.

Useful? React with 👍 / 👎.


## Active Source

`docs_build/dev/ProjectInstructions/` is the only active Project Instructions source.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve migrated rules in the active instruction source

With this line making docs_build/dev/ProjectInstructions/ the only active source and the old root PROJECT_INSTRUCTIONS.md deleted, any rule that was not copied into this tree becomes inactive. I checked the active ProjectInstructions tree (excluding archived history) for several previously mandatory sections such as TOOL STATUS GOVERNANCE, PLAYWRIGHT DEPTH AND COVERAGE REQUIREMENT, and HTML FILE RESTRICTIONS, and found no replacements, so future tool/runtime PRs lose those gates despite this being a consolidation rather than a policy removal. Please migrate or link the existing rules before deprecating the old file.

Useful? React with 👍 / 👎.

Comment on lines +50 to +51
- `docs_build/dev/PROJECT_INSTRUCTIONS.md` (delete)
- `docs_build/dev/PROJECT_MULTI_PC.txt` (delete)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update queued PR docs before deleting their source files

Deleting these root instruction files leaves existing queued work orders under docs_build/pr/ pointing at paths that no longer exist. I checked active PR docs outside archives/reports and found examples such as docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/BUILD_PR.md still telling Codex to use both docs_build/dev/PROJECT_INSTRUCTIONS.md and docs_build/dev/PROJECT_MULTI_PC.txt; running those work orders now starts with missing source-of-truth files. Please either keep compatibility stubs or update the queued PR docs to the new docs_build/dev/ProjectInstructions/ paths before removing the old files.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants