Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions admin/system-health.html

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# PR_26177_CHARLIE_006-system-health-dashboard-complete

Team: Charlie
Branch: PR_26177_CHARLIE_006-system-health-dashboard-complete
Base: main
Scope: System Health Dashboard completion polish

## Summary

- Removed stale foundation and placeholder wording from the Admin System Health dashboard source.
- Kept unavailable provider metrics explicit with safe `PENDING` status and clear reasons.
- Updated service health cards to display `PASS`, `WARN`, `FAIL`, or `NOT CONFIGURED` directly.
- Preserved the Web UI to API/service contract flow; the browser still renders only server-owned System Health data.
- Added targeted assertions for placeholder removal, service status display, secret masking, current-environment-only checks, and externalized Theme V2 script/style rules.

## Changed Files

- `admin/system-health.html`
- `src/dev-runtime/server/local-api-router.mjs`
- `tests/dev-runtime/AdminHealthOperations.test.mjs`
- `tests/playwright/tools/AdminHealthOperationsPage.spec.mjs`
- `docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete.md`
- `docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_branch-validation.md`
- `docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_requirements-checklist.md`
- `docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_validation-lane.md`
- `docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_manual-validation-notes.md`
- `docs_build/dev/reports/codex_changed_files.txt`
- `docs_build/dev/reports/codex_review.diff`

## Validation

- PASS: `node --check src/dev-runtime/server/local-api-router.mjs`
- PASS: `node --check tests/dev-runtime/AdminHealthOperations.test.mjs`
- PASS: `node --check tests/playwright/tools/AdminHealthOperationsPage.spec.mjs`
- PASS: `node --test tests/dev-runtime/AdminHealthOperations.test.mjs tests/api/admin-system-health/contract.test.mjs`
- PASS: `npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1`

## Artifact

- `tmp/PR_26177_CHARLIE_006-system-health-dashboard-complete_delta.zip`
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# PR_26177_CHARLIE_006 Branch Validation

Result: PASS

Checks:
- PASS: Started from `main`.
- PASS: Worktree was clean before branch creation.
- PASS: Local/origin sync was `0/0` before branch creation.
- PASS: Branch `PR_26177_CHARLIE_006-system-health-dashboard-complete` was created from current `main`.
- PASS: Scope stayed within System Health Dashboard completion.
- PASS: No `start_of_day` files changed.
- PASS: No direct commits to `main`.
- PASS: PR branch retained for review.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# PR_26177_CHARLIE_006 Manual Validation Notes

- Confirmed System Health dashboard copy no longer contains stale `foundation PR`, `foundation view`, `placeholder`, `Pending metric`, or `intentionally not wired` wording.
- Confirmed provider metrics that are not available remain visibly marked `PENDING` with explanatory reasons.
- Confirmed service cards retain existing Theme V2 card layout while displaying direct health status values.
- Confirmed secret-like runtime variables remain masked as `********`.
- Confirmed current-environment System Health behavior remains intact; peer environments are reference-only.
- Confirmed no runtime/UI/API/database files outside the scoped System Health files were changed.
- Confirmed no `start_of_day` files were changed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# PR_26177_CHARLIE_006 Requirement Checklist

- PASS: Environment Summary remains current-deployment only.
- PASS: Postgres Health remains API/service-owned and displays safe values only.
- PASS: R2/Storage Health remains current-environment only.
- PASS: Runtime Environment Variables render from server-owned diagnostics.
- PASS: Runtime variables remain alphabetically sorted by key.
- PASS: Secret-like runtime values remain masked.
- PASS: Service Health cards now display direct `PASS`, `WARN`, `FAIL`, or `NOT CONFIGURED` text.
- PASS: Stale foundation and placeholder wording removed from the dashboard source.
- PASS: Empty/error states remain explicit `PENDING`, `WARN`, or `FAIL` with reasons.
- PASS: Theme V2 layout and externalized scripts/styles preserved.
- PASS: No inline styles, style blocks, script blocks, or inline event handlers introduced.
- PASS: Browser does not own authoritative product data.
- PASS: No MEM DB, local-mem, fake-login, browser storage SSoT, silent fallback, hidden default, or SQLite direction introduced.
- PASS: Targeted tests updated and run.
- PASS: Required reports and delta ZIP created.
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# PR_26177_CHARLIE_006 Validation Lane

Impacted lanes:
- Admin System Health page
- Local API Admin System Health status contract
- System Health Playwright page coverage

Commands:
- PASS: `node --check src/dev-runtime/server/local-api-router.mjs`
- PASS: `node --check tests/dev-runtime/AdminHealthOperations.test.mjs`
- PASS: `node --check tests/playwright/tools/AdminHealthOperationsPage.spec.mjs`
- PASS: `node --test tests/dev-runtime/AdminHealthOperations.test.mjs tests/api/admin-system-health/contract.test.mjs`
- 6 tests passed.
- PASS: `npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1`
- 3 tests passed.

Skipped lanes:
- Full samples smoke was not run; this PR only touches targeted Admin System Health dashboard behavior and tests.

Result: PASS
42 changes: 28 additions & 14 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,14 +1,28 @@
docs_build/dev/BUILD_PR.md
docs_build/dev/PLAN_PR.md
docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md
docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md
docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions.md
docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions_branch-validation.md
docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions_instruction-compliance-checklist.md
docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions_manual-validation-notes.md
docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions_requirement-checklist.md
docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions_validation-lane.md
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/codex_review.diff
src/shared/math/randomHelpers.js
src/shared/validation/assert.js
# git status --short
M admin/system-health.html
M docs_build/dev/reports/codex_changed_files.txt
M docs_build/dev/reports/codex_review.diff
M src/dev-runtime/server/local-api-router.mjs
M tests/dev-runtime/AdminHealthOperations.test.mjs
M tests/playwright/tools/AdminHealthOperationsPage.spec.mjs
?? docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete.md
?? docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_branch-validation.md
?? docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_manual-validation-notes.md
?? docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_requirements-checklist.md
?? docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_validation-lane.md

# git ls-files --others --exclude-standard
docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete.md
docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_branch-validation.md
docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_manual-validation-notes.md
docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_requirements-checklist.md
docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_validation-lane.md

# git diff --stat
admin/system-health.html | 40 +-
docs_build/dev/reports/codex_changed_files.txt | 42 +-
docs_build/dev/reports/codex_review.diff | 765 +++++++++------------
src/dev-runtime/server/local-api-router.mjs | 10 +-
tests/dev-runtime/AdminHealthOperations.test.mjs | 3 +-
.../tools/AdminHealthOperationsPage.spec.mjs | 4 +-
6 files changed, 393 insertions(+), 471 deletions(-)
Loading
Loading