Skip to content

PR_26177_DELTA_056-shared-validation-assertions#208

Merged
ToolboxAid merged 1 commit into
mainfrom
PR_26177_DELTA_056-shared-validation-assertions
Jun 26, 2026
Merged

PR_26177_DELTA_056-shared-validation-assertions#208
ToolboxAid merged 1 commit into
mainfrom
PR_26177_DELTA_056-shared-validation-assertions

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

PR_26177_DELTA_056-shared-validation-assertions

Date: 2026-06-26
Team: Delta
Scope: Shared validation assertions extracted from random helper code
Status: PASS

Summary

  • Added src/shared/validation/assert.js.
  • Moved generic reusable assertion helpers out of src/shared/math/randomHelpers.js.
  • Included only the current generic assertion helpers needed by random helpers: assertArray, assertFiniteNumber, and assertOrderedRange.
  • Updated randomHelpers.js to import those assertions from the shared validation module.
  • Preserved existing Random, RandomSeed, and random helper behavior.
  • Did not change public API.
  • Did not add unrelated validation helpers.
  • No UI, API, database, or unrelated cleanup changes were made.

Branch Validation

PASS. Branch PR_26177_DELTA_056-shared-validation-assertions was created from clean PR_26177_DELTA_055-random-seed-enhancements.

Changed Files

  • docs_build/dev/PLAN_PR.md
  • docs_build/dev/BUILD_PR.md
  • docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md
  • docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md
  • src/shared/validation/assert.js
  • src/shared/math/randomHelpers.js
  • docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions.md
  • docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions_branch-validation.md
  • docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions_requirement-checklist.md
  • docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions_validation-lane.md
  • docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions_manual-validation-notes.md
  • docs_build/dev/reports/PR_26177_DELTA_056-shared-validation-assertions_instruction-compliance-checklist.md
  • docs_build/dev/reports/codex_changed_files.txt
  • docs_build/dev/reports/codex_review.diff

Validation

  • PASS: node ./scripts/run-node-test-files.mjs tests/shared/RandomHelpers.test.mjs tests/shared/Random.test.mjs tests/shared/RandomSeed.test.mjs
  • PASS: node --check src/shared/validation/assert.js
  • PASS: node --check src/shared/math/randomHelpers.js
  • PASS: git diff --check
  • SKIP: Playwright was not run because this PR does not change UI or browser runtime flows.

Artifact

  • tmp/PR_26177_DELTA_056-shared-validation-assertions_delta.zip

@ToolboxAid ToolboxAid marked this pull request as ready for review June 26, 2026 03:43
@ToolboxAid ToolboxAid changed the base branch from PR_26177_DELTA_055-random-seed-enhancements to main June 26, 2026 03:44
@ToolboxAid ToolboxAid merged commit 8cdd87b into main Jun 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants