Skip to content

PR_26177_DELTA_054-random-utility#206

Merged
ToolboxAid merged 1 commit into
mainfrom
PR_26177_DELTA_054-random-utility
Jun 26, 2026
Merged

PR_26177_DELTA_054-random-utility#206
ToolboxAid merged 1 commit into
mainfrom
PR_26177_DELTA_054-random-utility

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

PR_26177_DELTA_054-random-utility

Date: 2026-06-26
Team: Delta
Scope: Nondeterministic shared Random utility and targeted unit tests
Status: PASS

Summary

  • Added Random as a nondeterministic shared random utility in src/shared/math/Random.js.
  • Added static convenience methods matching the public shape requested: next, nextInt, nextFloat, pick, shuffle, chance, weightedPick, and uuid.
  • Reused internal helper logic from PR_053.
  • Preferred crypto.getRandomValues() when available.
  • Used Math.random() only as compatibility fallback when crypto random values are unavailable.
  • Did not add deterministic seed support to Random.
  • Added targeted unit tests in tests/shared/Random.test.mjs.
  • No browser storage, UI, API, database, or existing game logic adoption changes were made.

Branch Validation

PASS. Branch PR_26177_DELTA_054-random-utility was created from PR_26177_DELTA_053-random-shared-helpers.

Changed Files

  • docs_build/dev/PLAN_PR.md
  • docs_build/dev/BUILD_PR.md
  • docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md
  • docs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.md
  • src/shared/math/Random.js
  • tests/shared/Random.test.mjs
  • docs_build/dev/reports/PR_26177_DELTA_054-random-utility.md
  • docs_build/dev/reports/PR_26177_DELTA_054-random-utility_branch-validation.md
  • docs_build/dev/reports/PR_26177_DELTA_054-random-utility_requirement-checklist.md
  • docs_build/dev/reports/PR_26177_DELTA_054-random-utility_validation-lane.md
  • docs_build/dev/reports/PR_26177_DELTA_054-random-utility_manual-validation-notes.md
  • docs_build/dev/reports/PR_26177_DELTA_054-random-utility_instruction-compliance-checklist.md
  • docs_build/dev/reports/codex_changed_files.txt
  • docs_build/dev/reports/codex_review.diff

Validation

  • PASS: node ./scripts/run-node-test-files.mjs tests/shared/Random.test.mjs tests/shared/RandomHelpers.test.mjs
  • PASS: node --check src/shared/math/Random.js
  • PASS: node --check tests/shared/Random.test.mjs
  • PASS: git diff --check
  • SKIP: Playwright was not run because this PR does not change UI or browser runtime flows.

Artifact

  • tmp/PR_26177_DELTA_054-random-utility_delta.zip

@ToolboxAid ToolboxAid marked this pull request as ready for review June 26, 2026 03:43
@ToolboxAid ToolboxAid changed the base branch from PR_26177_DELTA_053-random-shared-helpers to main June 26, 2026 03:43
@ToolboxAid ToolboxAid merged commit 7c8d20e into main Jun 26, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e39164fd0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +53 to +57
Active assignment: PR_26177_DELTA_054-random-utility.

Active branch: PR_26177_DELTA_053-random-shared-helpers.
Active branch: PR_26177_DELTA_054-random-utility.

Active PR: PR_26177_DELTA_053-random-shared-helpers.
Active PR: PR_26177_DELTA_054-random-utility.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Move the PR_054 assignment under Team Delta

This updated Team Alfa section now assigns PR_26177_DELTA_054-random-utility to Alfa even though the table above lists Team Alfa as Available and Team Delta as the active owner for that same PR, and the Team Delta section below still says none/Available. Since this file declares the registry must match TEAM_ASSIGNMENTS.md, readers get contradictory ownership for PR_054; these updated assignment/branch/PR lines should be under Team Delta or Alfa should remain unassigned.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants