PR_26177_DELTA_052-random-seed-utility#204
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 964043422d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Status: Active | ||
|
|
||
| Active assignment: none. | ||
| Active assignment: PR_26177_DELTA_052-random-seed-utility. |
There was a problem hiding this comment.
This block is under ## Team Alfa, but it marks Alfa active with the Delta random-seed assignment while the table above and ACTIVE_TEAM_REGISTRY.md mark Team Delta as the owner, and the Team Delta section below still says available. Because these assignment docs are required to match, downstream agents can incorrectly treat Alfa as busy and Delta as free for the active PR.
Useful? React with 👍 / 👎.
|
|
||
| function assertFiniteNumber(value, name) { | ||
| if (!Number.isFinite(value)) { | ||
| throw new TypeError(`${name} must be a finite number.`); |
There was a problem hiding this comment.
In environments that run the shared-extraction guard, this direct Number.isFinite usage is reported as a new inline-helper-clone violation for src/shared/math/RandomSeed.js; I confirmed npm run check:shared-extraction-guard adds this file to the unexpected violations. Reuse the existing shared finite-number helper instead of adding a new direct check here so the guard does not regress.
Useful? React with 👍 / 👎.
2 participants
PR_26177_DELTA_052-random-seed-utility
Date: 2026-06-26
Team: Delta
Scope: Shared JavaScript utility and targeted unit tests
Status: PASS
Summary
RandomSeed.seed(value),next(),nextInt(min, max),nextFloat(min, max), andpick(array).tests/shared/RandomSeed.test.mjs.Math.random()usage; no call sites were replaced.Branch Validation
PASS. Work started from clean
mainsynchronized withorigin/mainat0e9aa23eee267edcc6aac0eb660185c4552128c8.Current PR branch:
PR_26177_DELTA_052-random-seed-utilityChanged Files
docs_build/dev/PLAN_PR.mddocs_build/dev/BUILD_PR.mddocs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.mddocs_build/dev/ProjectInstructions/team_assignments/ACTIVE_TEAM_REGISTRY.mdsrc/shared/math/RandomSeed.jstests/shared/RandomSeed.test.mjsdocs_build/dev/reports/PR_26177_DELTA_052-random-seed-utility.mddocs_build/dev/reports/PR_26177_DELTA_052-random-seed-utility_branch-validation.mddocs_build/dev/reports/PR_26177_DELTA_052-random-seed-utility_requirement-checklist.mddocs_build/dev/reports/PR_26177_DELTA_052-random-seed-utility_validation-lane.mddocs_build/dev/reports/PR_26177_DELTA_052-random-seed-utility_manual-validation-notes.mddocs_build/dev/reports/PR_26177_DELTA_052-random-seed-utility_instruction-compliance-checklist.mddocs_build/dev/reports/codex_changed_files.txtdocs_build/dev/reports/codex_review.diffValidation
node ./scripts/run-node-test-files.mjs tests/shared/RandomSeed.test.mjsnode --check src/shared/math/RandomSeed.jsnode --check tests/shared/RandomSeed.test.mjsgit diff --checkArtifact
tmp/PR_26177_DELTA_052-random-seed-utility_delta.zip