PR_26177_CHARLIE_034-startup-runtime-report-cleanup#183
Conversation
7ce2fae to
83c19bc
Compare
5a1df79 to
5cf6a87
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5cf6a87fde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `Configured API URL: ${String(env.GAMEFOUNDRY_API_URL || "").trim() || defaultApiUrl(localServer.baseUrl)}`, | ||
| `Configured site URL: ${configuredSiteUrl}`, | ||
| `Configured API URL: ${configuredApiUrl}`, | ||
| `Local API URL: ${configuredApiUrl}`, |
There was a problem hiding this comment.
Report the actual local API URL
When GAMEFOUNDRY_API_URL points somewhere other than the server that just bound locally (for example a shared/dev API URL while localServer.baseUrl is http://127.0.0.1:5599), this new Local API URL line prints the configured public URL instead of the local endpoint. That duplicates Configured API URL and hides the actual local /api URL/port users need for startup troubleshooting; derive this line from localServer.baseUrl instead.
Useful? React with 👍 / 👎.
| `Configured site URL: ${configuredSiteUrl}`, | ||
| `Configured API URL: ${configuredApiUrl}`, | ||
| `Local API URL: ${configuredApiUrl}`, | ||
| `Local site URL: ${configuredSiteUrl}`, |
There was a problem hiding this comment.
Redact credentials from the local site URL
When GAMEFOUNDRY_SITE_URL includes URL credentials, such as http://site-user:site-secret@127.0.0.1:5500, this new Local site URL line writes the raw value to startup logs. That bypasses the URL-credential redaction used for environment diagnostics and exposes the embedded username/password; redact URL credentials before printing this diagnostic.
Useful? React with 👍 / 👎.
Summary
Validation
Artifact