Skip to content

PR_26177_CHARLIE_034-startup-runtime-report-cleanup#183

Merged
ToolboxAid merged 1 commit into
mainfrom
pr/26177-CHARLIE-034-startup-runtime-report-cleanup
Jun 25, 2026
Merged

PR_26177_CHARLIE_034-startup-runtime-report-cleanup#183
ToolboxAid merged 1 commit into
mainfrom
pr/26177-CHARLIE-034-startup-runtime-report-cleanup

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Polish Local API startup/runtime diagnostics with explicit Local API URL, local site URL/port, database mode, and storage status.
  • Keep environment variable diagnostics alphabetized and masked for PASSWORD, SECRET, TOKEN, KEY, SERVICE_ROLE, and JWT markers.
  • Surface the safe diagnostics through the System Health API payload and UI tests.

Validation

  • PASS: node --check scripts/start-local-api-server.mjs
  • PASS: node --check src/dev-runtime/server/local-api-router.mjs
  • PASS: node --test tests/dev-runtime/LocalApiStartupLogging.test.mjs
  • PASS: node --test tests/api/admin-system-health/contract.test.mjs
  • PASS: node --test tests/dev-runtime/AdminHealthOperations.test.mjs
  • PASS: npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1 --reporter=line
  • PASS: git diff --check

Artifact

  • tmp/PR_26177_CHARLIE_034-startup-runtime-report-cleanup_delta.zip

@ToolboxAid ToolboxAid force-pushed the pr/26177-CHARLIE-032-runtime-health-json-endpoints branch 2 times, most recently from 7ce2fae to 83c19bc Compare June 25, 2026 19:35
@ToolboxAid ToolboxAid force-pushed the pr/26177-CHARLIE-034-startup-runtime-report-cleanup branch from 5a1df79 to 5cf6a87 Compare June 25, 2026 19:37
@ToolboxAid ToolboxAid marked this pull request as ready for review June 25, 2026 19:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5cf6a87fde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

`Configured API URL: ${String(env.GAMEFOUNDRY_API_URL || "").trim() || defaultApiUrl(localServer.baseUrl)}`,
`Configured site URL: ${configuredSiteUrl}`,
`Configured API URL: ${configuredApiUrl}`,
`Local API URL: ${configuredApiUrl}`,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Report the actual local API URL

When GAMEFOUNDRY_API_URL points somewhere other than the server that just bound locally (for example a shared/dev API URL while localServer.baseUrl is http://127.0.0.1:5599), this new Local API URL line prints the configured public URL instead of the local endpoint. That duplicates Configured API URL and hides the actual local /api URL/port users need for startup troubleshooting; derive this line from localServer.baseUrl instead.

Useful? React with 👍 / 👎.

`Configured site URL: ${configuredSiteUrl}`,
`Configured API URL: ${configuredApiUrl}`,
`Local API URL: ${configuredApiUrl}`,
`Local site URL: ${configuredSiteUrl}`,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Redact credentials from the local site URL

When GAMEFOUNDRY_SITE_URL includes URL credentials, such as http://site-user:site-secret@127.0.0.1:5500, this new Local site URL line writes the raw value to startup logs. That bypasses the URL-credential redaction used for environment diagnostics and exposes the embedded username/password; redact URL credentials before printing this diagnostic.

Useful? React with 👍 / 👎.

@ToolboxAid ToolboxAid changed the base branch from pr/26177-CHARLIE-032-runtime-health-json-endpoints to main June 25, 2026 19:51
@ToolboxAid ToolboxAid merged commit 0c29879 into main Jun 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant