PR_26177_CHARLIE_031-environment-health-comparison#180
Conversation
ToolboxAid
force-pushed
the
pr/26177-CHARLIE-030-r2-storage-health-expanded-validation
branch
from
3acec8b to
8455fb6
Compare
ToolboxAid
force-pushed
the
pr/26177-CHARLIE-031-environment-health-comparison
branch
from
7fe5f7b to
1a63c19
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a63c192d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rows, | ||
| secretEditingAllowed: false, | ||
| secretsExposed: false, | ||
| status: rows.some((row) => row.activeCheck) ? "PASS" : "WARN", |
There was a problem hiding this comment.
When the current identity itself is warning, such as when the environment is inferred from GAMEFOUNDRY_ENVIRONMENT_LABEL without an approved storage prefix, the active comparison row is correctly marked WARN above, but this return value still reports environmentComparison.status as PASS merely because an active row exists. API consumers using the section status will see a healthy comparison even though the only actively checked environment is warning; compute this from the active row status instead of active-row existence.
Useful? React with 👍 / 👎.
ToolboxAid
changed the base branch from
pr/26177-CHARLIE-030-r2-storage-health-expanded-validation
to
main
1 participant
Summary
noCrossEnvironmentChecks.Stack
pr/26177-CHARLIE-030-r2-storage-health-expanded-validationValidation
node --check src/dev-runtime/server/local-api-router.mjsnode --check assets/theme-v2/js/admin-system-health.jsnode --test tests/api/admin-system-health/contract.test.mjsnode --test tests/dev-runtime/AdminHealthOperations.test.mjsnpx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1 --reporter=linegit diff --checkArtifact
tmp/PR_26177_CHARLIE_031-environment-health-comparison_delta.zipDo not merge without Owner approval.