PR_26177_CHARLIE_030-r2-storage-health-expanded-validation#178
Conversation
ToolboxAid
force-pushed
the
pr/26177-CHARLIE-030-r2-storage-health-expanded-validation
branch
from
3acec8b to
8455fb6
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8455fb6d2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const actionId of SYSTEM_HEALTH_STORAGE_ACTION_IDS) { | ||
| results.push(await this.runStorageConnectivityAction(actionId, { scope })); | ||
| } |
There was a problem hiding this comment.
When a configured R2 bucket allows both the upload and delete steps to pass, this stores the standalone upload result unchanged in storageDiagnostics; that row still reports cleanupStatus: "requires-delete-action" and permanentObjectCreated: true even though the same expanded validation just deleted the object and the top-level result reports no permanent object. Consumers of the storage-check / expanded-validation contract will see contradictory cleanup metadata in successful real-storage runs, so the upload diagnostic should be reconciled after the delete result is known.
Useful? React with 👍 / 👎.
| if (actionId === SYSTEM_HEALTH_STORAGE_EXPANDED_VALIDATION_ACTION_ID) { | ||
| return this.runStorageExpandedValidation(options); | ||
| } |
There was a problem hiding this comment.
Because this special case sits in the shared connectivity helper, the existing /api/admin/infrastructure/storage-connectivity-action handler also accepts actionId: "storage-expanded-validation" even though it calls this helper without the System Health environment-folder scope. In that route, the new action runs the full list/upload/read/delete sequence against the default project-prefix target instead of the current environment folder, so a hidden action can mutate a broader prefix despite the expanded validation being scoped and tested as System Health current-environment-only.
Useful? React with 👍 / 👎.
ToolboxAid
changed the base branch from
pr/26177-CHARLIE-029-system-health-postgres-metrics-panel
to
main
1 participant
Summary
Stack
pr/26177-CHARLIE-029-system-health-postgres-metrics-panelValidation
node --check src/dev-runtime/server/local-api-router.mjsnode --check assets/theme-v2/js/admin-system-health.jsnode --check src/api/admin-system-health-api-client.jsnode --test tests/api/admin-system-health/contract.test.mjsnode --test tests/dev-runtime/AdminHealthOperations.test.mjsnpx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1 --reporter=linegit diff --checkArtifact
tmp/PR_26177_CHARLIE_030-r2-storage-health-expanded-validation_delta.zipDo not merge without Owner approval.