-
Notifications
You must be signed in to change notification settings - Fork 0
PR_26175_OWNER_055: retain legal governance leftovers #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # PR_26175_OWNER_055-legal-governance-leftover-retention | ||
|
|
||
| ## Purpose | ||
| Retain the legal/governance leftover artifacts that remained after `PR_26175_OWNER_054-legal-corrected-package` was merged and `main` was synchronized. | ||
|
|
||
| ## Source Leftovers | ||
| The previous `MAIN_VERIFY` identified three untracked leftover paths: | ||
|
|
||
| | Path | Classification | Retention decision | | ||
| | --- | --- | --- | | ||
| | `docs_build/legal/IMPLEMENTATION.md` | Legal package implementation/source notes | Retained in this follow-up PR. | | ||
| | `docs_build/legal/LEGAL_CHANGELOG.md` | Legal foundation package governance notes | Retained in this follow-up PR. | | ||
| | `docs_build/dev/reports/PR_26175_OWNER_current-open-pr-status.md` | Generated governance status report | Retained as a snapshot report in this follow-up PR. | | ||
|
|
||
| ## Implementation | ||
| - Added the retained package implementation instructions at `docs_build/legal/IMPLEMENTATION.md`. | ||
| - Added the retained legal changelog at `docs_build/legal/LEGAL_CHANGELOG.md`. | ||
| - Updated and retained `docs_build/dev/reports/PR_26175_OWNER_current-open-pr-status.md` as a current governance snapshot taken after OWNER_054 was merged and before OWNER_055 was opened. | ||
| - Added OWNER_055 plan, validation, checklist, manual validation, changed-files, review-diff, and delta ZIP outputs. | ||
| - Confirmed no `IMPLEMENTATION.md` file remains at the repository root. | ||
|
|
||
| ## Validation Commands | ||
| - PASS: `git status --short --branch` | ||
| - PASS: `git rev-list --left-right --count origin/main...HEAD` | ||
| - PASS: `git diff --name-only` | ||
| - PASS: `git diff --check` | ||
| - PASS: targeted retained-file existence checks. | ||
| - PASS: targeted root `IMPLEMENTATION.md` absence check. | ||
| - PASS: targeted changed-file scope check confirmed documentation/governance/report files only. | ||
|
|
||
| ## Guardrails | ||
| - No product files were modified. | ||
| - No runtime code was modified. | ||
| - No `IMPLEMENTATION.md` file remains at the repository root. | ||
| - No branches were deleted. | ||
| - `stash@{0}` was left untouched. | ||
| - No leftover file was moved to `tmp/`. | ||
| - No leftover file was deleted. | ||
|
|
||
| ## Delta ZIP | ||
| Repo-structured delta ZIP: | ||
|
|
||
| `tmp/PR_26175_OWNER_055-legal-governance-leftover-retention_delta.zip` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # PR_26175_OWNER_055-legal-governance-leftover-retention Branch Validation | ||
|
|
||
| ## Result | ||
| PASS | ||
|
|
||
| ## Branch | ||
| - Working branch: `codex/pr-26175-owner-055-legal-governance-leftover-retention` | ||
| - Base branch: `main` | ||
| - Base commit at branch creation: `0c0f2ebc00b40409ea6ebc013a59729747926daf` | ||
|
|
||
| ## Checks | ||
| | Check | Result | | ||
| | --- | --- | | ||
| | Branch created from current `main` | PASS | | ||
| | `origin/main` fetched before branch work | PASS | | ||
| | Local branch contains one documentation/governance purpose | PASS | | ||
| | Product files unchanged | PASS | | ||
| | Stash left untouched | PASS | | ||
| | No branch deletion performed | PASS | | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # PR_26175_OWNER_055-legal-governance-leftover-retention Manual Validation Notes | ||
|
|
||
| ## Manual Review | ||
| - Confirmed `docs_build/legal/IMPLEMENTATION.md` contains legal foundation implementation instructions/source notes rather than unrelated temporary content. | ||
| - Confirmed `IMPLEMENTATION.md` is not present at the repository root. | ||
| - Confirmed `docs_build/legal/LEGAL_CHANGELOG.md` belongs to the legal foundation package governance notes. | ||
| - Confirmed `docs_build/dev/reports/PR_26175_OWNER_current-open-pr-status.md` is a generated governance report snapshot. | ||
| - Confirmed this PR does not intentionally alter product files, runtime code, UI, legal page rendering, branches, or stashes. | ||
|
|
||
| ## Notes | ||
| - `stash@{0}` remains untouched. | ||
| - Retained files were committed to preserve legal/governance provenance after OWNER_054. | ||
| - No owner-approved move-to-`tmp/` or deletion action was performed. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # PR_26175_OWNER_055-legal-governance-leftover-retention Requirement Checklist | ||
|
|
||
| | Requirement | Status | Notes | | ||
| | --- | --- | --- | | ||
| | PLAN_PR created | PASS | Added `docs_build/pr/PLAN_PR_26175_OWNER_055-legal-governance-leftover-retention.md`. | | ||
| | BUILD_PR completed | PASS | Added this documentation/governance retention report bundle. | | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This checklist marks Useful? React with 👍 / 👎. |
||
| | APPLY_PR ready | PASS | Changes are scoped for a normal PR. | | ||
| | Retain `docs_build/legal/IMPLEMENTATION.md` only if it contains legal package source notes | PASS | File contains legal foundation implementation instructions/source notes. | | ||
| | Do not leave `IMPLEMENTATION.md` at repo root | PASS | Root file absent; retained copy is `docs_build/legal/IMPLEMENTATION.md`. | | ||
| | Retain `docs_build/legal/LEGAL_CHANGELOG.md` only if it belongs to the legal package | PASS | File documents legal foundation package version 1.0. | | ||
| | Retain current open PR status report only if creating report-retention PR | PASS | This PR is the report-retention/legal-governance follow-up. | | ||
| | Do not modify product files | PASS | Only documentation/governance/report paths are changed. | | ||
| | Do not alter `stash@{0}` | PASS | Stash was not touched. | | ||
| | Do not delete branches | PASS | No branch deletion was performed. | | ||
| | Produce repo-structured ZIP under `tmp/` | PASS | `tmp/PR_26175_OWNER_055-legal-governance-leftover-retention_delta.zip`. | | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # PR_26175_OWNER_055-legal-governance-leftover-retention Validation Lane | ||
|
|
||
| ## Lane | ||
| Documentation/governance retention lane. | ||
|
|
||
| ## Validation Performed | ||
| | Validation | Result | | ||
| | --- | --- | | ||
| | `git status --short --branch` | PASS | | ||
| | `git rev-list --left-right --count origin/main...HEAD` | PASS | | ||
| | `git diff --name-only` | PASS | | ||
| | `git diff --check` | PASS | | ||
| | Required retained files exist | PASS | | ||
| | Root `IMPLEMENTATION.md` absent | PASS | | ||
| | Required OWNER_055 reports exist | PASS | | ||
| | Changed-file scope excludes product/runtime files | PASS | | ||
| | Delta ZIP exists under `tmp/` | PASS | | ||
|
|
||
| ## Runtime Validation | ||
| Not run. This PR is documentation/governance-only and does not change runtime code, UI, legal page content, or tests. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # PR_26175_OWNER_current-open-pr-status | ||
|
|
||
| ## Snapshot Scope | ||
| This governance snapshot was refreshed after `PR_26175_OWNER_054-legal-corrected-package` was merged and before opening `PR_26175_OWNER_055-legal-governance-leftover-retention`. | ||
|
|
||
| ## MAIN_VERIFY Snapshot | ||
| | Item | Result | | ||
| | --- | --- | | ||
| | Current branch at verification | `main` | | ||
| | Current main commit | `0c0f2ebc00b40409ea6ebc013a59729747926daf` (`0c0f2ebc`) | | ||
| | Local/origin sync | `0 0` | | ||
| | Open PR count before OWNER_055 | `0` | | ||
| | Draft PR count before OWNER_055 | `0` | | ||
| | Worktree state before OWNER_055 branch | Dirty, untracked leftovers only | | ||
| | Product files modified | No | | ||
| | Stashes altered | No | | ||
|
|
||
| ## Retained Leftovers | ||
| | Path | Classification | OWNER_055 disposition | | ||
| | --- | --- | --- | | ||
| | `docs_build/legal/IMPLEMENTATION.md` | Legal package implementation/source notes | Retain in legal governance follow-up PR. | | ||
| | `docs_build/legal/LEGAL_CHANGELOG.md` | Legal foundation package governance notes | Retain in legal governance follow-up PR. | | ||
| | `docs_build/dev/reports/PR_26175_OWNER_current-open-pr-status.md` | Generated governance status report | Retain as this refreshed snapshot. | | ||
|
|
||
| ## Stashes | ||
| | Stash | Description | Action | | ||
| | --- | --- | --- | | ||
| | `stash@{0}` | `On codex/pr-26175-alfa-047-theme-v2-svg-icon-registry: MAIN_VERIFY preserve pre-existing uncommitted OWNER_050 files before main sync` | Retained; not altered | | ||
|
|
||
| ## Recommendation | ||
| Proceed with `PR_26175_OWNER_055-legal-governance-leftover-retention` as a small documentation/governance PR. Do not delete leftovers, move leftovers to `tmp/`, alter stashes, or delete branches unless separately approved by the owner. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,11 @@ | ||
| assets/theme-v2/js/gamefoundry-partials.js | ||
| assets/theme-v2/js/legal-document-page.js | ||
| assets/theme-v2/partials/footer.html | ||
| docs_build/dev/reports/PR_26175_OWNER_054-legal-corrected-package.md | ||
| docs_build/dev/reports/PR_26175_OWNER_055-legal-governance-leftover-retention.md | ||
| docs_build/dev/reports/PR_26175_OWNER_055-legal-governance-leftover-retention_branch-validation.md | ||
| docs_build/dev/reports/PR_26175_OWNER_055-legal-governance-leftover-retention_manual-validation-notes.md | ||
| docs_build/dev/reports/PR_26175_OWNER_055-legal-governance-leftover-retention_requirement-checklist.md | ||
| docs_build/dev/reports/PR_26175_OWNER_055-legal-governance-leftover-retention_validation-lane.md | ||
| docs_build/dev/reports/PR_26175_OWNER_current-open-pr-status.md | ||
| docs_build/dev/reports/codex_changed_files.txt | ||
| docs_build/dev/reports/codex_review.diff | ||
| docs_build/dev/reports/coverage_changed_js_guardrail.txt | ||
| docs_build/dev/reports/playwright_v8_coverage_report.txt | ||
| legal/community-guidelines.html | ||
| legal/community-guidelines.md | ||
| legal/cookie-policy.html | ||
| legal/cookie-policy.md | ||
| legal/cookies-policy.html | ||
| legal/copyright-policy.html | ||
| legal/copyright-policy.md | ||
| legal/disclaimer.html | ||
| legal/dmca-policy.html | ||
| legal/dmca-policy.md | ||
| legal/index.html | ||
| legal/index.md | ||
| legal/legal-nav.js | ||
| legal/privacy-policy.html | ||
| legal/privacy-policy.md | ||
| legal/terms.html | ||
| legal/terms-of-service.html | ||
| legal/terms-of-service.md | ||
| tests/playwright/tools/RemainingLegalPages.spec.mjs | ||
| docs_build/legal/IMPLEMENTATION.md | ||
| docs_build/legal/LEGAL_CHANGELOG.md | ||
| docs_build/pr/PLAN_PR_26175_OWNER_055-legal-governance-leftover-retention.md |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| # Legal Foundation Implementation Instructions | ||
|
|
||
| ## PR | ||
|
|
||
| Use: | ||
|
|
||
| `PR_26175_OWNER_050-legal-foundation` | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When these retained implementation notes are used for provenance, this PR identifier sends readers to the wrong work: the repo already uses Useful? React with 👍 / 👎. |
||
|
|
||
| ## Goal | ||
|
|
||
| Publish the initial Game Foundry Studio legal foundation. | ||
|
|
||
| ## Required Pages | ||
|
|
||
| Create or update: | ||
|
|
||
| ```text | ||
| /legal/index.html | ||
| /legal/terms-of-service.html | ||
| /legal/privacy-policy.html | ||
| /legal/cookie-policy.html | ||
| /legal/community-guidelines.html | ||
| /legal/copyright-policy.html | ||
| /legal/dmca-policy.html | ||
| /legal/legal-nav.js | ||
| ``` | ||
|
|
||
| ## Source Drafts | ||
|
|
||
| Use the markdown files in `/legal/` from this package as the source content for the HTML pages. | ||
|
|
||
| ## Single Source of Truth Legal Menu | ||
|
|
||
| The left-side legal menu on all legal pages must be rendered from one shared source of truth. | ||
|
|
||
| Do not duplicate legal side-menu links in each HTML file. | ||
|
|
||
| Suggested file: | ||
|
|
||
| ```text | ||
| /legal/legal-nav.js | ||
| ``` | ||
|
|
||
| Suggested SSoT: | ||
|
|
||
| ```js | ||
| const LEGAL_NAV_ITEMS = [ | ||
| { href: "/legal/index.html", label: "Legal Overview" }, | ||
| { href: "/legal/terms-of-service.html", label: "Terms of Service" }, | ||
| { href: "/legal/privacy-policy.html", label: "Privacy Policy" }, | ||
| { href: "/legal/cookie-policy.html", label: "Cookie Policy" }, | ||
| { href: "/legal/community-guidelines.html", label: "Community Guidelines" }, | ||
| { href: "/legal/copyright-policy.html", label: "Copyright Policy" }, | ||
| { href: "/legal/dmca-policy.html", label: "DMCA Policy" } | ||
| ]; | ||
| ``` | ||
|
|
||
| Each legal page should include only a mount point: | ||
|
|
||
| ```html | ||
| <nav class="legal-side-nav" aria-label="Legal documents" data-legal-nav></nav> | ||
| ``` | ||
|
|
||
| Required JavaScript behavior: | ||
|
|
||
| - Render the legal navigation links from `LEGAL_NAV_ITEMS`. | ||
| - Detect the current page from `window.location.pathname`. | ||
| - Normalize `/legal/` to `/legal/index.html`. | ||
| - Apply an active/current class to the matching legal page. | ||
| - Set `aria-current="page"` on the active link. | ||
| - Preserve keyboard and tab accessibility. | ||
| - Do not require inline event handlers. | ||
|
|
||
| Suggested current-page logic: | ||
|
|
||
| ```js | ||
| function normalizeLegalPath(pathname) { | ||
| if (pathname.endsWith("/legal/")) return "/legal/index.html"; | ||
| if (pathname === "/legal") return "/legal/index.html"; | ||
| return pathname; | ||
| } | ||
| ``` | ||
|
|
||
| ## Layout Requirements | ||
|
|
||
| - Use the existing Game Foundry Studio site shell/template where appropriate. | ||
| - Legal pages should use a two-column layout on desktop: | ||
| - Left: shared legal side navigation | ||
| - Right: legal document content | ||
| - On small screens, the legal navigation may stack above the content. | ||
| - Keep the legal pages readable and accessible. | ||
| - Do not introduce unrelated UI changes. | ||
|
|
||
| ## Footer Links | ||
|
|
||
| Add footer links to: | ||
|
|
||
| - Terms | ||
| - Privacy | ||
| - Cookies | ||
| - Community Guidelines | ||
| - Copyright | ||
| - DMCA | ||
|
|
||
| Footer links may point to the corresponding `/legal/*.html` pages. | ||
|
|
||
| ## Validation Requirements | ||
|
|
||
| Run the repository's relevant validation before opening the PR. | ||
|
|
||
| At minimum: | ||
|
|
||
| - HTML validation or existing static-page checks, if present | ||
| - JS syntax check for `/legal/legal-nav.js` | ||
| - Existing legal/nav/footer tests, if present | ||
| - Any repository-required governance validation | ||
|
|
||
| ## Acceptance Criteria | ||
|
|
||
| - All six legal documents are published as HTML pages. | ||
| - `/legal/index.html` links to all legal documents. | ||
| - Footer includes legal links. | ||
| - Legal side navigation is generated from one SSoT. | ||
| - Current page is visually selected. | ||
| - Current page has `aria-current="page"`. | ||
| - No page has a hand-maintained duplicate left legal menu. | ||
| - No unrelated code, route, database, API, or storage changes. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Legal Changelog | ||
|
|
||
| ## Version 1.0 — June 24, 2026 | ||
|
|
||
| Initial legal foundation package for Game Foundry Studio LLC. | ||
|
|
||
| Included: | ||
|
|
||
| - Legal Overview | ||
| - Terms of Service | ||
| - Privacy Policy | ||
| - Cookie Policy | ||
| - Community Guidelines | ||
| - Copyright Policy | ||
| - DMCA Policy | ||
|
|
||
| Implementation requirements added: | ||
|
|
||
| - Public `/legal/` page structure | ||
| - Footer legal links | ||
| - Shared left-side legal navigation | ||
| - `/legal/legal-nav.js` as the single source of truth | ||
| - JavaScript current-page selection using `window.location.pathname` | ||
| - `aria-current="page"` on the selected legal page |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # PLAN PR_26175_OWNER_055-legal-governance-leftover-retention | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This new PLAN reuses Useful? React with 👍 / 👎. |
||
|
|
||
| Source of truth: user request `PLAN_PR PR_26175_OWNER_055-legal-governance-leftover-retention`. | ||
|
|
||
| ## Purpose | ||
| Retain the legal/governance leftover artifacts identified after `PR_26175_OWNER_054-legal-corrected-package` was merged, using a small documentation-only follow-up PR. | ||
|
|
||
| ## Scope | ||
| Primary target files: | ||
| - `docs_build/legal/IMPLEMENTATION.md` | ||
| - `docs_build/legal/LEGAL_CHANGELOG.md` | ||
| - `docs_build/dev/reports/PR_26175_OWNER_current-open-pr-status.md` | ||
| - `docs_build/pr/PLAN_PR_26175_OWNER_055-legal-governance-leftover-retention.md` | ||
| - `docs_build/dev/reports/PR_26175_OWNER_055-legal-governance-leftover-retention.md` | ||
| - `docs_build/dev/reports/PR_26175_OWNER_055-legal-governance-leftover-retention_branch-validation.md` | ||
| - `docs_build/dev/reports/PR_26175_OWNER_055-legal-governance-leftover-retention_requirement-checklist.md` | ||
| - `docs_build/dev/reports/PR_26175_OWNER_055-legal-governance-leftover-retention_validation-lane.md` | ||
| - `docs_build/dev/reports/PR_26175_OWNER_055-legal-governance-leftover-retention_manual-validation-notes.md` | ||
| - `docs_build/dev/reports/codex_review.diff` | ||
| - `docs_build/dev/reports/codex_changed_files.txt` | ||
| - `tmp/PR_26175_OWNER_055-legal-governance-leftover-retention_delta.zip` | ||
|
|
||
| ## Required Changes | ||
| - Retain `docs_build/legal/IMPLEMENTATION.md` because it contains legal package implementation/source notes. | ||
| - Retain `docs_build/legal/LEGAL_CHANGELOG.md` because it belongs to the legal foundation package governance notes. | ||
| - Retain `docs_build/dev/reports/PR_26175_OWNER_current-open-pr-status.md` as a generated governance report snapshot. | ||
| - Add the normal OWNER_055 plan, validation, checklist, manual notes, changed-files, review-diff, and ZIP outputs. | ||
|
|
||
| ## Validation | ||
| Run only: | ||
| - `git status --short --branch` | ||
| - `git rev-list --left-right --count origin/main...HEAD` | ||
| - `git diff --name-only` | ||
| - `git diff --check` | ||
| - Targeted checks that retained files and required OWNER_055 reports exist. | ||
| - Targeted check that changed files are documentation/governance/report files only. | ||
|
|
||
| ## Non-goals | ||
| - Do not modify product files. | ||
| - Do not modify runtime code. | ||
| - Do not delete branches. | ||
| - Do not alter stashes. | ||
| - Do not move leftovers to `tmp/`. | ||
| - Do not delete leftovers. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When APPLY/Closed gates rely on this branch-validation evidence, this report can incorrectly approve a PR that was created on a branch outside the repo's required naming standard:
docs_build/dev/PROJECT_INSTRUCTIONS.mdrequirespr/<YYJJJ>-<TEAM>-<###>-<short-description>with the TEAM token preserved, but the recorded branch iscodex/pr-26175-owner-055-...and the checks below still mark branch creation as PASS. Please either record/use the compliantpr/26175-OWNER-055-...branch or mark this validation as failing.Useful? React with 👍 / 👎.