PR_26175_OWNER_054: apply corrected legal package#175
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0626d9b226
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <link rel="icon" href="/favicon.svg"> | ||
| <link rel="stylesheet" href="../assets/theme-v2/css/theme.css"> | ||
| <meta charset="utf-8"> | ||
| <meta http-equiv="refresh" content="0; url=terms-of-service.html"> |
There was a problem hiding this comment.
With this meta-refresh in place, the still-present tests/playwright/tools/TermsOfServicePage.spec.mjs continues to visit /legal/terms.html and assert the old GameFoundryStudio title plus [data-legal-document-*] diagnostics/API-rendered content. When that spec runs, it lands on the new static Terms page and both Terms tests fail, so update or remove that spec as part of this migration.
Useful? React with 👍 / 👎.
| @@ -1,50 +0,0 @@ | |||
| <!doctype html> | |||
There was a problem hiding this comment.
Deleting this page leaves tests/playwright/tools/EnvironmentBannerCoverage.spec.mjs:19 pointing at /legal/disclaimer.html for the legal-family coverage case. When that coverage spec runs, the request now returns the test server's 404 response instead of a shared-layout legal page, so either retarget the matrix to an existing legal URL or keep a compatibility redirect.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,37 @@ | |||
| const LEGAL_NAV_ITEMS = [ | |||
| { href: "/legal/index.html", label: "Legal Overview" }, | |||
There was a problem hiding this comment.
When the static site is served from a path prefix instead of the domain root, these absolute /legal/... hrefs send users to the host root and normalizeLegalPath(window.location.pathname) no longer matches them, so navigation and current-page highlighting break for the legal menu. The shared footer/header routing rewrites data-route links relative to the current page; generate these links the same way or make them relative.
Useful? React with 👍 / 👎.
| DMCA Agent / Legal Contact<br> | ||
| legal@gamefoundrystudio.com<br> | ||
| https://gamefoundrystudio.com</p> | ||
| <p>A physical mailing address should be added before relying on this policy for formal registered DMCA agent purposes.</p> |
There was a problem hiding this comment.
This public DMCA page now ships an implementation note telling users that a physical mailing address still needs to be added before relying on the policy. Since the page is presented as the approved static legal copy, leaving this placeholder in the rendered policy can mislead copyright reporters and undermines the corrected legal package’s claim that no placeholder legal copy remains.
Useful? React with 👍 / 👎.
2 participants
Summary
gfs_legal_corrected_package.ziplegal content for the canonical public legal pages.legal/legal-nav.jsas the single runtime SSoT for the legal side menu.Root Cause
The previous legal pages mixed placeholder static pages with a dynamic renderer (
legal-document-page.js) that depended on unavailable published legal document registry content. That left approved legal copy absent and produced missing-document warnings. The side menus were duplicated and inconsistent across legal pages.Validation
README.md,CODEX_FIX_INSTRUCTIONS.md, and every/legal/file.aria-current="page", correct titles, document bodies, no console errors, and noPublished legal documentwarnings.npx playwright test tests/playwright/tools/RemainingLegalPages.spec.mjs --project=playwright --reporter=line --workers=1node --test tests/dev-runtime/LegalFoundation.test.mjsgit diff --cached --checklegalorassets/theme-v2.tmp/PR_26175_OWNER_054-legal-corrected-package_delta.zip.Notes
CODEX_FIX_INSTRUCTIONS.mdwas treated as authoritative. The package HTML contained repeated<noscript>fallback nav blocks, so those were removed to satisfy the no-duplicate-navigation and SSoT requirements. Package markdown trailing-space hard breaks were normalized so repository whitespace checks pass; public approved HTML content remains intact.