Skip to content

PR_26175_ALFA_050-theme-v2-layout-utility-icons#169

Merged
ToolboxAid merged 1 commit into
mainfrom
codex/pr-26175-alfa-050-theme-v2-layout-utility-icons
Jun 24, 2026
Merged

PR_26175_ALFA_050-theme-v2-layout-utility-icons#169
ToolboxAid merged 1 commit into
mainfrom
codex/pr-26175-alfa-050-theme-v2-layout-utility-icons

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Apply shared Theme V2 SVG registry icons to layout utility controls: fullscreen/exit-fullscreen, previous/next navigation, horizontal collapse/expand toggles, and return-to-top.
  • Add compact layout icon CSS and route/status/registry coverage for the utility icons.
  • Include required ALFA_050 reports plus repo-structured delta ZIP under tmp/ locally.

Validation

  • PASS: node --check assets/theme-v2/js/theme-icons.js
  • PASS: node --check assets/theme-v2/js/tool-display-mode.js
  • PASS: node --check assets/theme-v2/js/gamefoundry-partials.js
  • PASS: npx playwright test tests/playwright/tools/ThemeV2SvgIconRegistry.spec.mjs --workers=1 (8 passed)
  • PASS: npx playwright test tests/playwright/tools/ToolboxSelectedGameStatusBar.spec.mjs --workers=1 (7 passed)
  • PASS: npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --workers=1 (11 passed)
  • PASS: targeted inline-style scan returned no matches
  • PASS: git diff --cached --check

Reports

  • docs_build/dev/reports/PR_26175_ALFA_050-theme-v2-layout-utility-icons_report.md
  • docs_build/dev/reports/PR_26175_ALFA_050-theme-v2-layout-utility-icons_validation-lane.md
  • docs_build/dev/reports/PR_26175_ALFA_050-theme-v2-layout-utility-icons_requirements-checklist.md
  • docs_build/dev/reports/PR_26175_ALFA_050-theme-v2-layout-utility-icons_manual-validation-notes.md
  • docs_build/dev/reports/codex_review.diff
  • docs_build/dev/reports/codex_changed_files.txt

Local ZIP: tmp/PR_26175_ALFA_050-theme-v2-layout-utility-icons_delta.zip

@ToolboxAid ToolboxAid force-pushed the codex/pr-26175-alfa-050-theme-v2-layout-utility-icons branch from 4e07536 to 016ebee Compare June 24, 2026 23:22
@ToolboxAid ToolboxAid force-pushed the codex/pr-26175-alfa-050-theme-v2-layout-utility-icons branch from 016ebee to 550ba2f Compare June 24, 2026 23:28
@ToolboxAid ToolboxAid marked this pull request as ready for review June 24, 2026 23:29

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 550ba2f63c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

async function exitToolMode() {
document.body.classList.remove("tool-focus-mode");
displayMode.open = true;
updateToolDisplayModeModeIcon();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Refresh the mode icon after fullscreen exit

When the browser Fullscreen API succeeds, this call runs before exitFullscreen() resolves, so document.fullscreenElement is still set and updateToolDisplayModeModeIcon() keeps rendering the exit-fullscreen icon even though tool-focus-mode has already been removed. The fullscreenchange handler does not refresh this click path because the body class is gone by then, so users who exit via the control keep seeing the wrong mode icon until they re-enter focus mode.

Useful? React with 👍 / 👎.

@ToolboxAid ToolboxAid merged commit 6a7a001 into main Jun 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants