PR_26175_ALFA_050-theme-v2-layout-utility-icons#169
Conversation
4e07536 to
016ebee
Compare
016ebee to
550ba2f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 550ba2f63c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| async function exitToolMode() { | ||
| document.body.classList.remove("tool-focus-mode"); | ||
| displayMode.open = true; | ||
| updateToolDisplayModeModeIcon(); |
There was a problem hiding this comment.
Refresh the mode icon after fullscreen exit
When the browser Fullscreen API succeeds, this call runs before exitFullscreen() resolves, so document.fullscreenElement is still set and updateToolDisplayModeModeIcon() keeps rendering the exit-fullscreen icon even though tool-focus-mode has already been removed. The fullscreenchange handler does not refresh this click path because the body class is gone by then, so users who exit via the control keep seeing the wrong mode icon until they re-enter focus mode.
Useful? React with 👍 / 👎.
Summary
tmp/locally.Validation
node --check assets/theme-v2/js/theme-icons.jsnode --check assets/theme-v2/js/tool-display-mode.jsnode --check assets/theme-v2/js/gamefoundry-partials.jsnpx playwright test tests/playwright/tools/ThemeV2SvgIconRegistry.spec.mjs --workers=1(8 passed)npx playwright test tests/playwright/tools/ToolboxSelectedGameStatusBar.spec.mjs --workers=1(7 passed)npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --workers=1(11 passed)git diff --cached --checkReports
docs_build/dev/reports/PR_26175_ALFA_050-theme-v2-layout-utility-icons_report.mddocs_build/dev/reports/PR_26175_ALFA_050-theme-v2-layout-utility-icons_validation-lane.mddocs_build/dev/reports/PR_26175_ALFA_050-theme-v2-layout-utility-icons_requirements-checklist.mddocs_build/dev/reports/PR_26175_ALFA_050-theme-v2-layout-utility-icons_manual-validation-notes.mddocs_build/dev/reports/codex_review.diffdocs_build/dev/reports/codex_changed_files.txtLocal ZIP:
tmp/PR_26175_ALFA_050-theme-v2-layout-utility-icons_delta.zip