PR_26175_ALFA_048-theme-v2-chevron-conversion#165
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c824b44fe1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function refreshVerticalAccordionChevrons() { | ||
| document.querySelectorAll("details.vertical-accordion").forEach(wireVerticalAccordionChevron); |
There was a problem hiding this comment.
Wire chevrons outside the tool-display initializer
After the CSS summary:after fallback was removed, vertical accordion chevrons now only appear when this one-time scan runs from tool-display-mode.js. That misses any page that has .vertical-accordion but no data-tool-display-mode/tool-display script, such as docs/faq.html and owner/design-system.html, and it also misses accordions rendered later by modules such as assets/toolbox/assets/js/index.js replacing its asset-type accordion container. In those contexts the accordions still expand/collapse, but they render with no chevron affordance at all.
Useful? React with 👍 / 👎.
Summary
Revalidation
node --check assets/theme-v2/js/theme-icons.jsnode --check assets/theme-v2/js/tool-display-mode.jsnode --check assets/toolbox/idea-board/js/index.jsnpx playwright test tests/playwright/tools/ThemeV2SvgIconRegistry.spec.mjs --workers=1npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --workers=1npx playwright test tests/playwright/tools/ToolboxSelectedGameStatusBar.spec.mjs --workers=1Reports
docs_build/dev/reports/codex_review.diffdocs_build/dev/reports/codex_changed_files.txtdocs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_report.mddocs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_validation-lane.mddocs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_requirements-checklist.mddocs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_manual-validation-notes.mdZIP
tmp/PR_26175_ALFA_048-theme-v2-chevron-conversion_delta.zip