Skip to content

PR_26175_ALFA_048-theme-v2-chevron-conversion#165

Merged
ToolboxAid merged 2 commits into
mainfrom
codex/pr-26175-alfa-048-theme-v2-chevron-conversion
Jun 24, 2026
Merged

PR_26175_ALFA_048-theme-v2-chevron-conversion#165
ToolboxAid merged 2 commits into
mainfrom
codex/pr-26175-alfa-048-theme-v2-chevron-conversion

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Convert Theme V2 chevron affordances to the shared SVG icon registry.
  • Keep behavior and UI scope limited to chevron icon rendering and associated test coverage.
  • Includes regenerated governance reports and repo-structured delta ZIP metadata for ALFA_048.

Revalidation

  • PASS: node --check assets/theme-v2/js/theme-icons.js
  • PASS: node --check assets/theme-v2/js/tool-display-mode.js
  • PASS: node --check assets/toolbox/idea-board/js/index.js
  • PASS: npx playwright test tests/playwright/tools/ThemeV2SvgIconRegistry.spec.mjs --workers=1
  • PASS: npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --workers=1
  • PASS: npx playwright test tests/playwright/tools/ToolboxSelectedGameStatusBar.spec.mjs --workers=1
  • PASS: Theme V2 chevron legacy pattern scan returned no matches.

Reports

  • docs_build/dev/reports/codex_review.diff
  • docs_build/dev/reports/codex_changed_files.txt
  • docs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_report.md
  • docs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_validation-lane.md
  • docs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_requirements-checklist.md
  • docs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_manual-validation-notes.md

ZIP

  • tmp/PR_26175_ALFA_048-theme-v2-chevron-conversion_delta.zip

@ToolboxAid ToolboxAid merged commit 3cb4ccc into main Jun 24, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c824b44fe1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +72 to +73
function refreshVerticalAccordionChevrons() {
document.querySelectorAll("details.vertical-accordion").forEach(wireVerticalAccordionChevron);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wire chevrons outside the tool-display initializer

After the CSS summary:after fallback was removed, vertical accordion chevrons now only appear when this one-time scan runs from tool-display-mode.js. That misses any page that has .vertical-accordion but no data-tool-display-mode/tool-display script, such as docs/faq.html and owner/design-system.html, and it also misses accordions rendered later by modules such as assets/toolbox/assets/js/index.js replacing its asset-type accordion container. In those contexts the accordions still expand/collapse, but they render with no chevron affordance at all.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants