[codex] PR_26171_063 codex instruction enforcement hardening#16
Conversation
…struction-enforcement-hardening # Conflicts: # docs_build/dev/reports/codex_changed_files.txt # docs_build/dev/reports/codex_review.diff
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f53ad4386
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Game Design | ||
| - Game Crew | ||
|
|
||
| Laptop / Environment 2 owns Content Creation and asset/publishing work: |
There was a problem hiding this comment.
For any Events-scoped PR, the new hard-stop rules require the PR owner to match this authoritative owner map, but this Laptop list omits the existing Events workstream even though toolbox/events/ exists and the earlier map in this file assigned Events to Laptop. After this change an Events PR has no matching owner and would be forced to stop before changes; include Events in the current map or state its new owner explicitly.
Useful? React with 👍 / 👎.
| - Any `FAIL` is a hard stop unless the PR explicitly scopes branch audit or recovery documentation without implementation. | ||
|
|
||
| Hard stops before changes: | ||
| - If the current branch is not `main`, HARD STOP. |
There was a problem hiding this comment.
When a Codex session starts on a leftover PR branch, this new gate is evaluated before every PR and the preceding rule makes the newest section authoritative, so this HARD STOP fires before the existing required workflow can perform step 2, Checkout main. That makes normal recovery from a previous branch impossible; either permit the documented checkout-to-main step before this check or scope the hard stop to non-main states that cannot be safely recovered.
Useful? React with 👍 / 👎.
| - Must document owner/parity compliance in the PR report. | ||
|
|
||
| Hard stop rules: | ||
| - If the PR number parity does not match the current machine, stop before changes. |
There was a problem hiding this comment.
For governance/recovery/diagnostics/instruction-hardening PRs where Master Control explicitly assigns the opposite environment, the rule just above says parity need not be followed, but this unconditional hard stop still stops whenever PR number parity differs from the current machine. That makes the documented override unusable; add the same exception to this hard stop.
Useful? React with 👍 / 👎.
2 participants
Summary
PROJECT_INSTRUCTIONS.md.PROJECT_MULTI_PC.txt.Validation
git diff --checkNotes