PR_26175_CHARLIE_007-system-health-environment-identity#151
Conversation
There was a problem hiding this comment.
💡 Codex Review
When the deployment uses the approved PRD storage prefix, loadStorageConfig only accepts /prod/projects/ (src/dev-runtime/storage/storage-config.mjs line 15), but this new model reports PRD as /prd. Because /prod is explicitly aliased to PRD later, a production health response can pass while displaying environmentIdentity.storageFolder: "/prd", and the reference map also tells operators to use a path that the storage config rejects.
HTML-JavaScript-Gaming/src/dev-runtime/server/local-api-router.mjs
Lines 910 to 919 in 930daf6
When storage prefix is unset and the deployment relies on the documented GAMEFOUNDRY_ENVIRONMENT_LABEL values, this parser only recognizes short codes plus Production; the .env.example labels Development Environment, Integration Testing Environment, and User Acceptance Testing Environment fall through to the Local default. In those environments the new identity section reports the wrong current deployment instead of DEV/IST/UAT.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Adds the current deployment Environment Identity section to Admin System Health and keeps the all-environment map as static reference content only.
Validation
node --check src/dev-runtime/server/local-api-router.mjsnode --check assets/theme-v2/js/admin-system-health.jsgit diff --checknode --test tests/dev-runtime/AdminHealthOperations.test.mjsnpx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1 --reporter=lineArtifact
tmp/PR_26175_CHARLIE_007-system-health-environment-identity_delta.zipNo merge requested.