PR_26174_ALFA_017-game-hub-guest-save-and-crew-cleanup#111
Closed
ToolboxAid wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
OWNER-approved closure: this historical Alfa PR is superseded by merged consolidated PR #149. No branch deletion requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
account/sign-in.htmlGame CrewaccordionGame,Purpose,Status,ActionsValidation
git diff --check -- toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjsnode --check toolbox/game-hub/game-hub.jsnpx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub"(11 passed)Artifact
tmp/PR_26174_ALFA_017-game-hub-guest-save-and-crew-cleanup_delta.zipNotes
A broader unscoped run of
npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjswas attempted first. It reported 12 passed and 2 failed; the ALFA_017 guest redirect assertion was fixed, and the remaining failure was outside this PR surface:Toolbox member-role filters focus tools without exposing admin-only controlsreceived existing500 /api/game-journey/completion-metricsresponses.