Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions assets/theme-v2/css/tables.css
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,8 @@ td {
cursor: pointer
}

.data-table [data-game-row][data-game-active="true"] {
background: color-mix(in srgb, var(--gold) 14%, var(--panel))
}

.data-table [data-game-row][data-game-active="true"] > th,
.data-table [data-game-row][data-game-active="true"] > td {
.data-table [data-game-active-cell="true"] {
box-shadow: inset var(--space-3) 0 0 var(--gold);
border-bottom-color: var(--gold-border-muted)
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Branch Validation: PASS

PASS - Current branch is pr/26174-ALFA-016-game-hub-row-edit-add-selected-state.
PASS - Branch was created from pr/26174-ALFA-015-game-hub-actions-and-setup-cleanup at ef771ff76.
PASS - Worktree was clean before creating the PR branch.
PASS - Scope is limited to Game Hub table add/edit selected-state behavior, Theme V2 table styling, targeted Playwright coverage, and required reports.
PASS - No protected Project Instructions files were modified.
PASS - No merge to main was performed.

Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Manual Validation Notes

PASS - Confirmed active-game selected styling is a thin Game-cell indicator, not a filled row background.
PASS - Confirmed active game uses the same background color as non-active game cells.
PASS - Confirmed active Game and Edit buttons do not use selected button styling.
PASS - Confirmed Edit remains a plain action until it opens an inline edit row.
PASS - Confirmed inline edit row shows Game, Purpose, Status, Owner, Actions columns with Save and Cancel.
PASS - Confirmed Game textbox is visible during edit and read-only because no rename API exists in the current Game Hub contract.
PASS - Confirmed Add Game row appears under the game table and expands to Game, Purpose, Status, Owner, Actions with Save and Cancel.
PASS - Confirmed add and edit saves use the existing repository API/service methods.
PASS - Confirmed Source Idea and Readiness Output child rows remain under expanded game parent rows.
PASS - Confirmed guest users can browse/select games but cannot add or edit.
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
Requirement Checklist: PASS

PASS - Selected state now appears as a thin indicator on the Game cell for the active game.
PASS - Active game does not use a filled row background.
PASS - Active game does not use a different background color.
PASS - Active Game button does not use selected button styling.
PASS - Edit button does not look selected while a row is merely active.
PASS - Add Game button/row appears under the game table.
PASS - Add row includes Game textbox, Purpose dropdown, and Status dropdown.
PASS - Add row actions show Save and Cancel.
PASS - Edit row actions show Save and Cancel.
PASS - Columns remain Game, Purpose, Status, Owner, Actions.
PASS - Source Idea child rows are preserved.
PASS - Readiness Output child rows are preserved.
PASS - table_first_ui.md and the Idea Board table-first add-row/edit-row pattern were followed.
PASS - No browser-owned product data was introduced.
PASS - No silent fallbacks were introduced.
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Validation Lane: PASS

Commands:
1. npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub preserves guest browsing and blocks guest saves|Game Hub shows a creator-safe empty state when no projects exist|Game Hub shows a creator-safe unavailable state when project list API fails|Game Hub displays and edits game purpose and member role|Game Hub readiness child rows update from mock game state"
Result: PASS - 7 passed.

2. npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"
Result: PASS - 1 passed.

3. git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs
Result: PASS.
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# PR_26174_ALFA_016-game-hub-row-edit-add-selected-state

## Purpose

Move Game Hub add/edit behavior into the game table and correct selected-state styling.

## Summary

- Moved the active-game indicator from the Actions edit button to a thin Game-cell indicator.
- Removed filled active-game background styling and selected-button appearance.
- Kept Edit as a plain row action and rendered Save/Cancel only while a row is editing.
- Added a bottom Add Game row that expands into Game, Purpose, and Status fields with Save/Cancel actions.
- Removed the old sidebar add-game form while preserving the existing API/service contract.
- Preserved Game, Purpose, Status, Owner, and Actions columns.
- Preserved Source Idea and Readiness Output child rows under game parent rows.

## Validation

PASS - `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub preserves guest browsing and blocks guest saves|Game Hub shows a creator-safe empty state when no projects exist|Game Hub shows a creator-safe unavailable state when project list API fails|Game Hub displays and edits game purpose and member role|Game Hub readiness child rows update from mock game state"`
PASS - `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"`
PASS - `git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs`
2 changes: 0 additions & 2 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
assets/theme-v2/css/tables.css
tests/playwright/tools/GameHubMockRepository.spec.mjs
tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
toolbox/game-hub/game-hub.js
toolbox/game-hub/index.html
Loading
Loading