Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions assets/theme-v2/css/tables.css
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,15 @@ td {
cursor: pointer
}

.data-table [data-game-row][data-game-active="true"] {
background: color-mix(in srgb, var(--gold) 14%, var(--panel))
}

.data-table [data-game-row][data-game-active="true"] > th,
.data-table [data-game-row][data-game-active="true"] > td {
border-bottom-color: var(--gold-border-muted)
}

.idea-board-idea-label {
display: inline-flex;
align-items: center;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Branch Validation: PASS

PASS - Current branch is pr/26174-ALFA-015-game-hub-actions-and-setup-cleanup.
PASS - Branch was created from pr/26174-ALFA-014-game-hub-parent-columns-center at 177840f74.
PASS - Worktree was clean before creating the PR branch.
PASS - Scope is limited to Game Hub UI/controller, Theme V2 table styling, targeted Playwright coverage, and required reports.
PASS - No protected Project Instructions files were modified.
PASS - No merge to main was performed.

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Manual Validation Notes

PASS - Confirmed Game Hub no longer renders the Game Setup accordion.
PASS - Confirmed Game Hub no longer renders the Open Game Journey action.
PASS - Confirmed parent table columns remain Game, Purpose, Status, Owner, Actions.
PASS - Confirmed visible parent row action text is Edit.
PASS - Confirmed Edit keeps using the repository open-game method and does not introduce browser-owned project arrays.
PASS - Confirmed the active game row exposes data-game-active="true", aria-current="true", and a non-transparent theme background.
PASS - Confirmed Source Idea and Readiness Output remain separate child tables under the expanded game row.
PASS - Confirmed Add submits through the existing create-game form/API path.
PASS - Confirmed safe empty and API-unavailable states still pass targeted Playwright validation.
NOTE - Full GameHubMockRepository.spec.mjs exploratory run had an unrelated toolbox-role completion-metrics 500 failure; scoped Game Hub validation passed.

Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
Requirement Checklist: PASS

PASS - Game Hub parent table Actions replaces Open {game} with Edit.
PASS - A clear active-game visual state is applied to the active game row.
PASS - Open Game Journey action was removed.
PASS - An Add button is present for adding a game to the list.
PASS - Game Setup accordion was removed.
PASS - Parent columns remain Game, Purpose, Status, Owner, Actions.
PASS - Source Idea remains a child row/table under the game parent row.
PASS - Readiness Output remains a child row/table under the game parent row.
PASS - Existing API/service contract was preserved.
PASS - No browser-owned product data was introduced.
PASS - No page-local arrays were introduced.
PASS - No silent fallbacks were introduced.
PASS - table_first_ui.md was followed by keeping game rows as parent rows with child tables beneath them.

Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
Validation Lane: PASS

Commands:
1. npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub preserves guest browsing and blocks guest saves|Game Hub shows a creator-safe empty state when no projects exist|Game Hub shows a creator-safe unavailable state when project list API fails|Game Hub displays and edits game purpose and member role|Game Hub readiness child rows update from mock game state"
Result: PASS - 7 passed.

2. npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"
Result: PASS - 1 passed.

3. git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
Result: PASS.

Non-gating observation:
- An exploratory full-file run of tests/playwright/tools/GameHubMockRepository.spec.mjs produced 13 passing tests and 1 failure in "Toolbox member-role filters focus tools without exposing admin-only controls" due repeated 500 responses from /api/game-journey/completion-metrics. The failing test is outside this PR's targeted Game Hub lane.

Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# PR_26174_ALFA_015-game-hub-actions-and-setup-cleanup

## Purpose

Clean up Game Hub parent-row actions and setup controls while preserving the parent/child table contract.

## Summary

- Replaced Game Hub parent-row `Open {game}` action text with `Edit`.
- Added a theme-backed active-game visual state on the active parent row.
- Removed the standalone Open Game Journey action from Game Hub.
- Replaced the old Game Setup accordion with a direct Add game control surface.
- Kept parent columns as Game, Purpose, Status, Owner, and Actions.
- Kept Source Idea and Readiness Output as child row tables under each game parent row.
- Preserved the existing API/service contract and did not add browser-owned project data.

## Validation

PASS - `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub preserves guest browsing and blocks guest saves|Game Hub shows a creator-safe empty state when no projects exist|Game Hub shows a creator-safe unavailable state when project list API fails|Game Hub displays and edits game purpose and member role|Game Hub readiness child rows update from mock game state"`
PASS - `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"`
PASS - `git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`

12 changes: 3 additions & 9 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
toolbox/game-hub/index.html
toolbox/game-hub/game-hub.js
assets/theme-v2/css/tables.css
tests/playwright/tools/GameHubMockRepository.spec.mjs
tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
docs_build/dev/reports/codex_review.diff
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/PR_26174_ALFA_014-game-hub-parent-columns-center.md
docs_build/dev/reports/PR_26174_ALFA_014-game-hub-parent-columns-center-branch-validation.txt
docs_build/dev/reports/PR_26174_ALFA_014-game-hub-parent-columns-center-requirement-checklist.txt
docs_build/dev/reports/PR_26174_ALFA_014-game-hub-parent-columns-center-validation-lane.txt
docs_build/dev/reports/PR_26174_ALFA_014-game-hub-parent-columns-center-manual-validation-notes.txt
toolbox/game-hub/game-hub.js
toolbox/game-hub/index.html
Loading
Loading