Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions docs_build/dev/ProjectInstructions/addendums/table_first_ui.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,69 @@ Avoid:

Reference implementation:
Idea Board is the reference implementation.


DB base
Creator Table 1
Parent Table *-1 user
Child Table -- *-1 Parent


No selected Items
┌──────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Idea Board │
├───────────────┬─────────────────────────────────────────┬───────────┬────────────┬─────────┬─────────┤
│ Idea │ Pitch │ Status │ Updated │ Notes │ Actions │
├───────────────┼─────────────────────────────────────────┼───────────┼────────────┼─────────┼─────────┤
│ Top Thougts │ Smartest person wins... │ Exploring │ 2026-06-20 │ 3 Notes │ Edit Del│
├───────────────┬─────────────────────────────────────────┬───────────┬────────────┬─────────┬─────────┤
│ Sky Orchard │ Grow floating islands... │ Exploring │ 2026-06-20 │ 3 Notes │ Edit Del│
├───────────────┴─────────────────────────────────────────┴───────────┴────────────┴─────────┴─────────┤
│ Clockwork... │ Deliver messages through looping city...│ New │ 2026-06-20 │ 0 Notes │ Edit Del│
├───────────────┴─────────────────────────────────────────┴───────────┴────────────┴─────────┴─────────┤
│ [ Add Idea ] │
└──────────────────────────────────────────────────────────────────────────────────────────────────────┘


Clicking {Sky Orchard {chevron down arrow}] Expands/Acording the Note(s) for that Idea
┌────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Idea Board │
├───────────────┬─────────────────────────────────────────┬───────────┬────────────┬─────────┬─────────┤
│ Idea │ Pitch │ Status │ Updated │ Notes │ Actions │
├───────────────┼─────────────────────────────────────────┼───────────┼────────────┼─────────┼─────────┤
│ Top Thougts │ Smartest person wins... │ Exploring │ 2026-06-20 │ 3 Notes │ Edit Del│
├───────────────┬─────────────────────────────────────────┬───────────┬────────────┬─────────┬─────────┤
│ Sky Orchard[^}│ Grow floating islands... │ Exploring │ 2026-06-20 │ 3 Notes │ Edit Del│
├───────────────┴─────────────────────────────────────────┴───────────┴────────────┴─────────┴─────────┤
│ Notes │
│ --------------------------------------------------------------------------------------------------- │
│ note 1 [Edit] [Delete] │
│ System seed note: compare early ideas before project creation. [Edit] │
│ Ask whether the core loop is planning, defense, or both. [Edit] [Delete] │
│ │
│ [ Add Note ] │
├───────────────┬─────────────────────────────────────────┬───────────┬────────────┬─────────┬─────────┤
│ Clockwork... │ Deliver messages through looping city...│ New │ 2026-06-20 │ 0 Notes │ Edit Del│
├───────────────┴─────────────────────────────────────────┴───────────┴────────────┴─────────┴─────────┤
│ [ Add Idea ] │
└──────────────────────────────────────────────────────────────────────────────────────────────────────┘

Clickin Add Idea
┌────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Idea Board │
├───────────────┬─────────────────────────────────────────┬───────────┬────────────┬─────────┬─────────┤
│ Idea │ Pitch │ Status │ Updated │ Notes │ Actions │
├───────────────┼─────────────────────────────────────────┼───────────┼────────────┼─────────┼─────────┤
│ Top Thougts │ Smartest person wins... │ Exploring │ 2026-06-20 │ 3 Notes │ Edit Del│
├───────────────┬─────────────────────────────────────────┬───────────┬────────────┬─────────┬─────────┤
│ Sky Orchard │ Grow floating islands... │ Exploring │ 2026-06-20 │ 3 Notes │ Edit Del│
├───────────────┴─────────────────────────────────────────┴───────────┴────────────┴─────────┴─────────┤
│ Clockwork... │ Deliver messages through looping city...│ New │ 2026-06-20 │ 0 Notes │ Edit Del│
├───────────────┴─────────────────────────────────────────┴───────────┴────────────┴─────────┴─────────┤
│ [input.....] │ [input.....] │ [Dropdown]│ [autofile] │ 0 Notes │ Save Can│
└──────────────────────────────────────────────────────────────────────────────────────────────────────┘





Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Branch Validation: PASS

PASS - Current branch is pr/26174-ALFA-013-game-hub-game-row-child-rows.
PASS - Expected branch is pr/26174-ALFA-013-game-hub-game-row-child-rows.
PASS - Branch remains stacked on PR_26174_ALFA_012.
PASS - Owner-updated docs_build/dev/ProjectInstructions/addendums/table_first_ui.md is committed on this branch and used as the parent/child table reference.
PASS - Work stayed scoped to Game Hub row rendering, targeted Playwright expectations, and required reports.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Manual Validation Notes: PASS

- Reviewed docs_build/dev/ProjectInstructions/addendums/table_first_ui.md as the owner-updated table-first reference.
- Compared Game Hub against the Idea Board parent row plus expanded child row pattern.
- Confirmed Game Hub no longer renders standalone Source Idea, Game Foundation, or Readiness Output panel/card sections.
- Confirmed Game Hub no longer uses an Open Games wrapper/accordion or Open Games table wrapper.
- Confirmed expanding a game creates exactly two child rows: Source Idea, then Readiness Output.
- Confirmed Source Idea remains read-only and the readiness rows use existing service-contract output.
- Confirmed safe empty and unavailable state checks still pass.
- Confirmed Idea Board-created Source Idea context still appears in Game Hub through the child table after reload.
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
Requirement Checklist: PASS

PASS - table_first_ui.md was used as the parent/child table reference.
PASS - Game row is the parent row.
PASS - Source Idea is a child row/table under the game row.
PASS - Readiness Output is a child row/table under the game row.
PASS - Source Idea and Readiness Output are no longer separate card/panel sections.
PASS - Open Games wrapper/accordion is not used.
PASS - Open Games wrapper/table identity is not used.
PASS - Game rows expand/collapse.
PASS - Expanded game rows show Source Idea first and Readiness Output second.
PASS - No new readiness math was added.
PASS - Existing API/service contract was preserved.
PASS - Safe empty/unavailable states were preserved by targeted validation.
PASS - No browser-owned project data was introduced.
PASS - No silent fallbacks were introduced.
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Validation Lane: PASS

Commands:
1. npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub shows a creator-safe empty state|Game Hub shows a creator-safe unavailable state|Game Hub readiness child rows update from mock game state"
Result: 5 passed.

2. npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"
Result: 1 passed.

3. git diff --check -- toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs docs_build/dev/reports/codex_review.diff docs_build/dev/reports/codex_changed_files.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows.md docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-branch-validation.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-requirement-checklist.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-validation-lane.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-manual-validation-notes.txt
Result: PASS.
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# PR_26174_ALFA_013-game-hub-game-row-child-rows

## Purpose

Correct Game Hub so each game is the parent row and Source Idea plus Readiness Output render only as child rows/child tables under that game row.

## Summary

- Applied the updated table_first_ui.md guidance and matched the Idea Board parent-row/expanded-child-row pattern.
- Removed the Open Games wrapper/accordion from the Game Hub page.
- Removed the Open Games wrapper/table identity from the Game Hub list table.
- Removed standalone Source Idea, Game Foundation, and Readiness Output panel/card sections.
- Kept Source Idea and Readiness Output as the two expanded child rows under each game parent row.
- Preserved the existing Game Hub API/service contract and safe empty/unavailable states.

## Validation

PASS - `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub shows a creator-safe empty state|Game Hub shows a creator-safe unavailable state|Game Hub readiness child rows update from mock game state"`
PASS - `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"`
PASS - `git diff --check -- toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs docs_build/dev/reports/codex_review.diff docs_build/dev/reports/codex_changed_files.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows.md docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-branch-validation.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-requirement-checklist.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-validation-lane.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-manual-validation-notes.txt`
14 changes: 9 additions & 5 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
docs_build/dev/ProjectInstructions/addendums/table_first_ui.md
toolbox/game-hub/index.html
toolbox/game-hub/game-hub.js
tests/playwright/tools/GameHubMockRepository.spec.mjs
tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
docs_build/dev/reports/codex_review.diff
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/PR_26174_ALFA_012-game-hub-parent-child-final-validation.md
docs_build/dev/reports/PR_26174_ALFA_012-game-hub-parent-child-final-validation-branch-validation.txt
docs_build/dev/reports/PR_26174_ALFA_012-game-hub-parent-child-final-validation-requirement-checklist.txt
docs_build/dev/reports/PR_26174_ALFA_012-game-hub-parent-child-final-validation-validation-lane.txt
docs_build/dev/reports/PR_26174_ALFA_012-game-hub-parent-child-final-validation-manual-validation-notes.txt
docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows.md
docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-branch-validation.txt
docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-requirement-checklist.txt
docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-validation-lane.txt
docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-manual-validation-notes.txt
Loading
Loading