Bump adm-zip and sst in /apps/web - #196
Conversation
Removes [adm-zip](https://github.com/cthackers/adm-zip). It's no longer used after updating ancestor dependency [sst](https://github.com/anomalyco/sst). These dependencies need to be updated together. Removes `adm-zip` Updates `sst` from 2.43.2 to 4.17.1 - [Release notes](https://github.com/anomalyco/sst/releases) - [Commits](https://github.com/anomalyco/sst/compare/sst@2.43.2...v4.17.1) --- updated-dependencies: - dependency-name: adm-zip dependency-version: dependency-type: indirect - dependency-name: sst dependency-version: 4.17.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce28de6e47
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "sst": "2.43.2", | ||
| "sst": "4.17.1", |
There was a problem hiding this comment.
Keep SST on v2 until the config is migrated
This bump installs SST v4, but the app still has the SST v2 deployment shape: sst.config.ts imports sst/constructs and exports config/stacks, while production deploys run npx sst deploy --stage prod from .github/workflows/cd.yml. SST’s migration docs for v3+ say the CDK/CloudFormation stack model was removed and config should be $config({ app, run }), so the deploy path will fail before updating production unless the SST config/site/cron definitions are migrated or the dependency remains on v2.
Useful? React with 👍 / 👎.
Removes adm-zip. It's no longer used after updating ancestor dependency sst. These dependencies need to be updated together.
Removes
adm-zipUpdates
sstfrom 2.43.2 to 4.17.1Release notes
Sourced from sst's releases.
... (truncated)
Commits
a0bd20fFix duplicate CloudWatch role URN on fresh accounts (#6911)8bfe1c1Addstate.retentionoption to prevent big state buckets (#6925)adcdb2fFixsst addrequiring Prettier (or other dependencies) (#6924)d1e8ff1Re-runFunctionEnvironmentUpdatewhen Lambda changes (#6920)9321c40Support custom MAIL FROM domain for SES (#6906)4f1a634Sync IAM permissions breakdown (#6898)9f23ba0Remove enteprise page from docse881243Limit CloudFront Function name length in domain redirects (#6889)817ac33Use supplied credentials in AWS SDK client (#6893)9cfa06cAdd Durable objects Component (#6785)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for sst since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.