Tests - #10
Merged
Merged
Conversation
…ns instead of accessing singleton directly
…r instead of accessing singleton directly
…injection for GameManager and GameStateManager
…ndency injection for SettingsManager and GameManager
…gs, navigation, and views Configure Vitest with coverage support, add test setup with console mocking, and implement unit tests for validators, commands, navigation strategies, and settings options. Add integration tests for GameView and SettingsView with mocked dependencies. Update ESLint and tsconfig to include test files, and extend .fallowrc.json to ignore test-related patterns and dependencies.
…test suite Update .fallowrc.json to include fallow-cov dependency, change vitest config extension to .mts, remove test file ignore patterns, add duplicates ignore for generated files, and configure health coverage path. Add coverage directory to .gitignore and configure VS Code settings with fallow.coverage.capturePath. Add fallow-ignore-file directive to index.ts. Simplify barrel exports in game UI components to use wildcard exports
… class, extract createSettingsManager test helper to shared module Remove GameEngineFactory interface and T3CoreFactory implementation as they are no longer needed. Extract createSettingsManager mock helper from settingsView.test.ts to tests/helpers/settings.ts for reuse across multiple test files. Add unit tests for actionKeysHandler and handleInputAnswer game input utilities. Refactor gameNavigation and settingsNavigation tests
…pters, and state management Add unit tests for GameInformations, BoardUI, GameEntryMessageUI, GameHeaderUI, GameHintUI, GameStatusMessageUI, InputErrorMessageUI, and PlayerPromptUI components. Add tests for T3CoreAdapter, GameManager, and GameStateManager services. Update .fallowrc.json to ignore tests/setup.ts file.
…ey handling services
…and edge cases in navigation and routing Add comprehensive unit tests for KeyHandler class covering initialization, start/stop lifecycle, keypress handling, position updates, and Ctrl+C behavior. Add tests for ListNavigationStrategy boundary conditions and movement. Add edge case tests for settingsNavigation with undefined position, renderRoute with unknown route, and styledLabel multi-argument handling.
…g, update tests to check initialPosition instead of position before start Add guard to KeyHandler.position getter to return null when handler is not running. Update unit tests to verify initialPosition property instead of position when handler hasn't started. Add _isRunning property override in keyHandler.test.ts to test position updates. Add debug console.log in GameView for keyHandler inspection.
…to single interactive workflow Replace publish-release.sh and release.sh with unified release.sh script that provides interactive release workflow with automatic rollback on failure. Update PUBLISHING.md to document new yarn release command with pre-flight checks, quality validation, npm availability verification, and changelog generation. Add color-coded output, step-by-step progress tracking, and comprehensive error handling.
Remove separate pull-request.yml workflow and merge all checks (lint, TypeScript, tests, build, fallow) into ci.yml. Rename 'test' job to 'check' and add yarn test:run and yarn build steps. Update PUBLISHING.md to reflect complete list of automated PR checks.
Replace yarn test:run with yarn test:coverage in CI workflow to generate coverage reports during automated checks.
Fallow health reportNo GitHub PR/MR findings. Generated by fallow. |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
…ow job naming Remove @fallow-cli/fallow-cov dependency from .fallowrc.json and configure coverage path directly in fallow commands. Update CI workflow to rename 'check' job to 'test', add descriptive names to all steps, and pass coverage-final.json to fallow health action. Add test step to publish workflow. Update fallow script in package.json to include coverage path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.